You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/17 23:41:02 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #8984: Z index registry / clean-up

rusackas opened a new pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This PR aims to simplify and consolidate the use of z-index values (z-indices?) throughout the codebase. 
   
   In the main `stylesheets/less/variables.less`, there are a few semantic layers onto which you can place elements. Add more if you want, but try to keep it minimal. Think of them like layers in Illustrator similar. 
   
   I found a handful of z-index values that appeared to make no difference, so I've removed them. This is the riskiest part of this PR, but for each of these, I poked around trying to find the element(s) in the UI and make sure that it looked the same before/after removing the value. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   n/a - everything should look identical, unless there's an instance of an element I missed that becomes obscured by being covered up.
   
   ### REVIEWERS
   @williaster (some of the z-index values I removed were yours, according to git — I hope I didn't break anything you added for good reason)
   @mistercrunch (you probably have some context about these elements too, and can make sure I didn't do anything stupid)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368183099
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
+/* Use double dash modifiers to step up/down from a base layer          */
+/* e.g. z-whatever--modifier                                            */
 /************************************************************************/
-@z-index-max: 1000;
-@z-index-dropdown: 11;
+
+/************************ toast messages, popovers **********************/
+@z-max: 3000;
+
+/***** filters, dashboard editor widgets, Explore reloading overlay *****/
+@z-dropdown: @z-above-dash-charts + 1;
+@z-above-dash-charts: 10;
 
 Review comment:
   why not `dashboard` instead of `dash`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368183501
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
+/* Use double dash modifiers to step up/down from a base layer          */
+/* e.g. z-whatever--modifier                                            */
 /************************************************************************/
-@z-index-max: 1000;
-@z-index-dropdown: 11;
+
+/************************ toast messages, popovers **********************/
+@z-max: 3000;
 
 Review comment:
   any reason you got rid of `index` in these var names? I kinda liked it in there

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368195070
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
+/* Use double dash modifiers to step up/down from a base layer          */
+/* e.g. z-whatever--modifier                                            */
 /************************************************************************/
-@z-index-max: 1000;
-@z-index-dropdown: 11;
+
+/************************ toast messages, popovers **********************/
+@z-max: 3000;
+
+/***** filters, dashboard editor widgets, Explore reloading overlay *****/
+@z-dropdown: @z-above-dash-charts + 1;
+@z-above-dash-charts: 10;
 
 Review comment:
   I was just trying to be terse... I'll make it dashboards, that's fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#issuecomment-577997876
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=h1) Report
   > Merging [#8984](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80672e8820bbd6239d3a9f3438142beb8ad0e153?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `79.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8984/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8984      +/-   ##
   ==========================================
   - Coverage   59.16%   59.15%   -0.02%     
   ==========================================
     Files         367      367              
     Lines       11679    11682       +3     
     Branches     2862     2864       +2     
   ==========================================
     Hits         6910     6910              
   - Misses       4590     4593       +3     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0FwcC5qc3g=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rset/assets/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9zbGljZUVudGl0aWVzLmpz) | `9.67% <ø> (ø)` | :arrow_up: |
   | [...ssets/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwuanN4) | `7.27% <0%> (ø)` | :arrow_up: |
   | [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.12% <0%> (ø)` | :arrow_up: |
   | [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `54.32% <0%> (-1.38%)` | :arrow_down: |
   | [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `77.55% <0%> (-0.8%)` | :arrow_down: |
   | [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQWRob2NNZXRyaWNFZGl0UG9wb3Zlci5qc3g=) | `62.35% <100%> (ø)` | :arrow_up: |
   | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `47.94% <100%> (ø)` | :arrow_up: |
   | [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0ZUZpbHRlckNvbnRyb2wuanN4) | `38.78% <100%> (ø)` | :arrow_up: |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/8984/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=footer). Last update [80672e8...25aef00](https://codecov.io/gh/apache/incubator-superset/pull/8984?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368195496
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
 
 Review comment:
   ![There is no try](https://media2.giphy.com/media/pvDp7Ewpzt0o8/giphy.gif)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368183350
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
 
 Review comment:
   Let's remove the `Try to` here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#issuecomment-577943545
 
 
   Sorry for the delay, was wrestling with my dev environment this week. I did some smoke tests and everything looks good to me!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#issuecomment-577248505
 
 
   @etr2460 we'd ❤️ your blessing before we merge this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#issuecomment-577995997
 
 
   Solved the 2 minor conflicts in Github UI, will merge once CI passes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368196297
 
 

 ##########
 File path: superset/assets/stylesheets/less/variables.less
 ##########
 @@ -107,9 +107,21 @@
 /* Z-INDEX                                                              */
 /* Think of the site as "layers" rather than an arms race of numbers    */
 /* Try to keep these to a minimum                                       */
+/* Try to label semantic "layers" and add comments for usage notes      */
+/* Use double dash modifiers to step up/down from a base layer          */
+/* e.g. z-whatever--modifier                                            */
 /************************************************************************/
-@z-index-max: 1000;
-@z-index-dropdown: 11;
+
+/************************ toast messages, popovers **********************/
+@z-max: 3000;
 
 Review comment:
   Just felt so dash-tastic with them in there! I figured just `z` captured the intent enough.
   
   That said, I don't have a strong opinion. `z-index-...` was my first notion, so I'm glad to hear you liked it... I'll put it back!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368195608
 
 

 ##########
 File path: superset/assets/src/messageToasts/stylesheets/toast.less
 ##########
 @@ -24,7 +24,7 @@
   left: 50%;
   transform: translate(-50%, 0);
   width: 600px;
-  z-index: 3000; // top of the world
+  z-index: @z-max; // top of the world
 
 Review comment:
   quite right! Thought I nabbed that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8984: Z index registry / clean-up

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #8984: Z index registry / clean-up
URL: https://github.com/apache/incubator-superset/pull/8984#discussion_r368183391
 
 

 ##########
 File path: superset/assets/src/messageToasts/stylesheets/toast.less
 ##########
 @@ -24,7 +24,7 @@
   left: 50%;
   transform: translate(-50%, 0);
   width: 600px;
-  z-index: 3000; // top of the world
+  z-index: @z-max; // top of the world
 
 Review comment:
   comment probably isn't required now right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org