You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2024/09/27 19:08:06 UTC
[PR] WIP on converting single-partition SAI queries to use SPRC [cassandra]
maedhroz opened a new pull request, #3584:
URL: https://github.com/apache/cassandra/pull/3584
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP on converting single-partition SAI queries to use SPRC [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #3584:
URL: https://github.com/apache/cassandra/pull/3584#discussion_r1779437813
##########
src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java:
##########
@@ -431,7 +431,8 @@ public void awaitResponses(boolean logBlockingReadRepairAttempt) throws ReadTime
// return immediately, or begin a read repair
if (digestResolver.responsesMatch())
{
- setResult(digestResolver.getData());
+ PartitionIterator data = digestResolver.getData();
+ setResult(command.filterForReplicaFilteringProtection().apply(data));
Review Comment:
This fixes a large class of problems where we need to filter, but I'm not entirely sure SRP/paging will work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] WIP on converting single-partition SAI queries to use SPRC [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #3584:
URL: https://github.com/apache/cassandra/pull/3584#discussion_r1779440436
##########
src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java:
##########
@@ -431,7 +431,8 @@ public void awaitResponses(boolean logBlockingReadRepairAttempt) throws ReadTime
// return immediately, or begin a read repair
if (digestResolver.responsesMatch())
{
- setResult(digestResolver.getData());
+ PartitionIterator data = digestResolver.getData();
+ setResult(command.filterForReplicaFilteringProtection().apply(data));
Review Comment:
I think we ultimately only want to use a single partition read command if we have a strict `RowFilter`. It's at least an incremental improvement that doesn't require us to worry too much about the short reads potentially caused by non-strict replica filtering coupled w/ strict coordinator filtering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org