You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/16 01:09:08 UTC

[GitHub] [iceberg] kbendick commented on a change in pull request #2736: Add schema validation before table import

kbendick commented on a change in pull request #2736:
URL: https://github.com/apache/iceberg/pull/2736#discussion_r670897796



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -437,6 +442,11 @@ private static void importUnpartitionedSparkTable(SparkSession spark, TableIdent
     }
   }
 
+  static boolean validateSchema(StructType srcSchema, Schema tgtSchema) {
+    StructType convertSchem = SparkSchemaUtil.convert(tgtSchema);

Review comment:
       Nit: `convertSchema` - missing last `a` in variable name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org