[jira] [Work logged] (ARTEMIS-4797) Failover connection references are not always cleaned up in NettyAcceptor, leaking memory

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-4797?focusedWorklogId=922212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922212 ]

ASF GitHub Bot logged work on ARTEMIS-4797:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/24 15:39
            Start Date: 05/Jun/24 15:39
    Worklog Time Spent: 10m 
      Work Description: joshb1050 opened a new pull request, #4960:
URL: https://github.com/apache/activemq-artemis/pull/4960

   If an exception is caught before the channel is deemed inactive, the reference to the Netty connection will not get destroyed and will leak memory in `NettyAcceptor`.
   
   This commit adds a flag when an exception is encountered so that the connection is still destroyed in this case when the channel becomes inactive.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 922212)
    Remaining Estimate: 0h
            Time Spent: 10m

> Failover connection references are not always cleaned up in NettyAcceptor, leaking memory
> -----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-4797
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4797
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>            Reporter: Josh Byster
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm still trying to parse through exactly what conditions this occurs in, since I'm able to reproduce it in a very specific production setup but not in an isolated environment locally.
> For context, we have custom slow consumer detection that closes connection IDs with slow consumers. These connections are connected via failover transport using client ActiveMQ Classic 5.16.4 (OpenWire). This seems to be specific to Netty.
> It appears this specific order of events causes the connection to not get cleaned up and retained indefinitely on the broker. With frequent kicking of connections, this ends up causing the broker to eventually OOM.
> 1. Connection is created, {{ActiveMQServerChannelHandler}} is created as well
> 2. {{ActiveMQServerChannelHandler#createConnection}} is called, {{active}} flag is set {{true}}.
> 3. A few minutes go by, then we call {{ActiveMQServerControl#closeConnectionWithID}} with the connection ID.
> 4. {{ActiveMQChannelHandler#exceptionCaught}} gets called—*this is the key point that causes issues*. The connection is cleaned up if and only if this is *not* called. The root cause of the exception is {{AbstractChannel.close(ChannelPromise)}}, however the comment above it says this is normal for failover.
> 5. The {{active}} flag is set to {{false}}.
> 6. {{ActiveMQChannelHandler#channelInactive}} gets called, but does *not* call {{listener.connectionDestroyed}} since the {{active}} flag is false.
> 7. The connection is never removed from the {{connections}} map in {{NettyAcceptor}}, causing a leak and eventual OOM of the broker if it happens frequently enough.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact