[GitHub] [spark] cloud-fan commented on a change in pull request #32678: [SPARK-35535][SQL] New data source V2 API: LocalScan

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32678:
URL: https://github.com/apache/spark/pull/32678#discussion_r640361752



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -104,6 +105,11 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat
         tableIdentifier = None)
       withProjectAndFilter(project, filters, dsScan, needsUnsafeConversion = false) :: Nil
 
+    case PhysicalOperation(project, filters,
+        DataSourceV2ScanRelation(_, scan: LocalScan, output)) =>
+      val localScanExec = LocalTableScanExec(output, scan.rows().toSeq)
+      withProjectAndFilter(project, filters, localScanExec, needsUnsafeConversion = true) :: Nil

Review comment:
       `LocalTableScanExec` always produce unsafe rows, I think `needsUnsafeConversion` should be false.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org