You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:31:04 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6054: riscv/riscv_schedulesigaction.c: Remove the duplicate state saving.
Ouss4 opened a new pull request, #6054:
URL: https://github.com/apache/incubator-nuttx/pull/6054
## Summary
State was being saved two times.
## Impact
Should have no impact, just remove duplication.
## Testing
esp32c3-devkit:ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6054: riscv/riscv_schedulesigaction.c: Remove the duplicate state saving.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6054:
URL: https://github.com/apache/incubator-nuttx/pull/6054#discussion_r848430539
##########
arch/risc-v/src/common/riscv_schedulesigaction.c:
##########
@@ -126,8 +126,6 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t sigdeliver)
* been delivered.
*/
- tcb->xcp.saved_regs = (uintptr_t *)CURRENT_REGS;
Review Comment:
@Ouss4, where is duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6054: riscv/riscv_schedulesigaction.c: Remove the duplicate state saving.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on code in PR #6054:
URL: https://github.com/apache/incubator-nuttx/pull/6054#discussion_r848448386
##########
arch/risc-v/src/common/riscv_schedulesigaction.c:
##########
@@ -126,8 +126,6 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t sigdeliver)
* been delivered.
*/
- tcb->xcp.saved_regs = (uintptr_t *)CURRENT_REGS;
Review Comment:
The call to `riscv_savestate(tcb->xcp.saved_regs);` does the same thing as this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6054: riscv/riscv_schedulesigaction.c: Remove the duplicate state saving.
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6054:
URL: https://github.com/apache/incubator-nuttx/pull/6054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org