You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Bill Bejeck <bb...@gmail.com> on 2018/09/17 19:43:01 UTC
[VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
All,
I'd like to start the voting process for KIP-372. Here's the link to the
updated proposal
https://cwiki.apache.org/confluence/display/KAFKA/KIP-372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
I'll start with my own +1.
Thanks,
Bill
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Bill Bejeck <bb...@gmail.com>.
All,
One additional minor change "Grouped.named" has been changed to
"Grouped.as". I've updated the KIP with this change.
Thanks,
Bill
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Bill Bejeck <bb...@gmail.com>.
All,
I've made a slight adjustment to the KIP and changed the "Joined.name" to
"Joined.named"
Thanks,
Bill
On Thu, Sep 20, 2018 at 4:49 PM Bill Bejeck <bb...@gmail.com> wrote:
> Hi All,
>
> KIP-372 is now accepted with:
> - 3 Binding +1 (Damian, Guozhang, Matthias)
> - 3 Non-binding +1 (Dongjin, John, Bill)
>
> Thanks to everyone for the votes.
>
> -Bill
>
> On Thu, Sep 20, 2018 at 7:30 AM Damian Guy <da...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> On Tue, 18 Sep 2018 at 16:33 Bill Bejeck <bb...@gmail.com> wrote:
>>
>> > All,
>> >
>> > In starting work on the PR for KIP-372, the Grouped interface needed
>> some
>> > method renaming to be more consistent with the other configuration
>> classes
>> > (Joined, Produced, etc.). As such I've updated the Grouped code
>> section of
>> > the KIP.
>> >
>> > As these changes address a comment from Matthias on the initial draft of
>> > the KIP and don't change any of the existing behavior already
>> outlined, I
>> > don't think a re-vote is required.
>> >
>> > Thanks,
>> > Bill
>> >
>> > On Tue, Sep 18, 2018 at 10:09 AM John Roesler <jo...@confluent.io>
>> wrote:
>> >
>> > > +1 (non-binding)
>> > >
>> > > Thanks!
>> > >
>> > > On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <do...@apache.org>
>> wrote:
>> > >
>> > > > Great improvements. +1. (Non-binding)
>> > > >
>> > > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <
>> matthias@confluent.io
>> > >
>> > > > wrote:
>> > > >
>> > > > > +1 (binding)
>> > > > >
>> > > > > -Matthias
>> > > > >
>> > > > > On 9/17/18 1:12 PM, Guozhang Wang wrote:
>> > > > > > +1 from me, thanks Bill !
>> > > > > >
>> > > > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <
>> bbejeck@gmail.com>
>> > > > wrote:
>> > > > > >
>> > > > > >> All,
>> > > > > >>
>> > > > > >> I'd like to start the voting process for KIP-372. Here's the
>> link
>> > > to
>> > > > > the
>> > > > > >> updated proposal
>> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> > > > > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
>> > > > > >>
>> > > > > >> I'll start with my own +1.
>> > > > > >>
>> > > > > >> Thanks,
>> > > > > >> Bill
>> > > > > >>
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > >
>> > > > --
>> > > > *Dongjin Lee*
>> > > >
>> > > > *A hitchhiker in the mathematical world.*
>> > > >
>> > > > *github: <http://goog_969573159/>github.com/dongjinleekr
>> > > > <http://github.com/dongjinleekr>linkedin:
>> > > kr.linkedin.com/in/dongjinleekr
>> > > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
>> > > > www.slideshare.net/dongjinleekr
>> > > > <http://www.slideshare.net/dongjinleekr>*
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Bill Bejeck <bb...@gmail.com>.
Hi All,
KIP-372 is now accepted with:
- 3 Binding +1 (Damian, Guozhang, Matthias)
- 3 Non-binding +1 (Dongjin, John, Bill)
Thanks to everyone for the votes.
-Bill
On Thu, Sep 20, 2018 at 7:30 AM Damian Guy <da...@gmail.com> wrote:
> +1 (binding)
>
> On Tue, 18 Sep 2018 at 16:33 Bill Bejeck <bb...@gmail.com> wrote:
>
> > All,
> >
> > In starting work on the PR for KIP-372, the Grouped interface needed some
> > method renaming to be more consistent with the other configuration
> classes
> > (Joined, Produced, etc.). As such I've updated the Grouped code section
> of
> > the KIP.
> >
> > As these changes address a comment from Matthias on the initial draft of
> > the KIP and don't change any of the existing behavior already outlined,
> I
> > don't think a re-vote is required.
> >
> > Thanks,
> > Bill
> >
> > On Tue, Sep 18, 2018 at 10:09 AM John Roesler <jo...@confluent.io> wrote:
> >
> > > +1 (non-binding)
> > >
> > > Thanks!
> > >
> > > On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <do...@apache.org>
> wrote:
> > >
> > > > Great improvements. +1. (Non-binding)
> > > >
> > > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <
> matthias@confluent.io
> > >
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > -Matthias
> > > > >
> > > > > On 9/17/18 1:12 PM, Guozhang Wang wrote:
> > > > > > +1 from me, thanks Bill !
> > > > > >
> > > > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bbejeck@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > >> All,
> > > > > >>
> > > > > >> I'd like to start the voting process for KIP-372. Here's the
> link
> > > to
> > > > > the
> > > > > >> updated proposal
> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
> > > > > >>
> > > > > >> I'll start with my own +1.
> > > > > >>
> > > > > >> Thanks,
> > > > > >> Bill
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > > --
> > > > *Dongjin Lee*
> > > >
> > > > *A hitchhiker in the mathematical world.*
> > > >
> > > > *github: <http://goog_969573159/>github.com/dongjinleekr
> > > > <http://github.com/dongjinleekr>linkedin:
> > > kr.linkedin.com/in/dongjinleekr
> > > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > > www.slideshare.net/dongjinleekr
> > > > <http://www.slideshare.net/dongjinleekr>*
> > > >
> > >
> >
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Damian Guy <da...@gmail.com>.
+1 (binding)
On Tue, 18 Sep 2018 at 16:33 Bill Bejeck <bb...@gmail.com> wrote:
> All,
>
> In starting work on the PR for KIP-372, the Grouped interface needed some
> method renaming to be more consistent with the other configuration classes
> (Joined, Produced, etc.). As such I've updated the Grouped code section of
> the KIP.
>
> As these changes address a comment from Matthias on the initial draft of
> the KIP and don't change any of the existing behavior already outlined, I
> don't think a re-vote is required.
>
> Thanks,
> Bill
>
> On Tue, Sep 18, 2018 at 10:09 AM John Roesler <jo...@confluent.io> wrote:
>
> > +1 (non-binding)
> >
> > Thanks!
> >
> > On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <do...@apache.org> wrote:
> >
> > > Great improvements. +1. (Non-binding)
> > >
> > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <matthias@confluent.io
> >
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > -Matthias
> > > >
> > > > On 9/17/18 1:12 PM, Guozhang Wang wrote:
> > > > > +1 from me, thanks Bill !
> > > > >
> > > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com>
> > > wrote:
> > > > >
> > > > >> All,
> > > > >>
> > > > >> I'd like to start the voting process for KIP-372. Here's the link
> > to
> > > > the
> > > > >> updated proposal
> > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
> > > > >>
> > > > >> I'll start with my own +1.
> > > > >>
> > > > >> Thanks,
> > > > >> Bill
> > > > >>
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > > --
> > > *Dongjin Lee*
> > >
> > > *A hitchhiker in the mathematical world.*
> > >
> > > *github: <http://goog_969573159/>github.com/dongjinleekr
> > > <http://github.com/dongjinleekr>linkedin:
> > kr.linkedin.com/in/dongjinleekr
> > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > www.slideshare.net/dongjinleekr
> > > <http://www.slideshare.net/dongjinleekr>*
> > >
> >
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Bill Bejeck <bb...@gmail.com>.
All,
In starting work on the PR for KIP-372, the Grouped interface needed some
method renaming to be more consistent with the other configuration classes
(Joined, Produced, etc.). As such I've updated the Grouped code section of
the KIP.
As these changes address a comment from Matthias on the initial draft of
the KIP and don't change any of the existing behavior already outlined, I
don't think a re-vote is required.
Thanks,
Bill
On Tue, Sep 18, 2018 at 10:09 AM John Roesler <jo...@confluent.io> wrote:
> +1 (non-binding)
>
> Thanks!
>
> On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <do...@apache.org> wrote:
>
> > Great improvements. +1. (Non-binding)
> >
> > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <ma...@confluent.io>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > -Matthias
> > >
> > > On 9/17/18 1:12 PM, Guozhang Wang wrote:
> > > > +1 from me, thanks Bill !
> > > >
> > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com>
> > wrote:
> > > >
> > > >> All,
> > > >>
> > > >> I'd like to start the voting process for KIP-372. Here's the link
> to
> > > the
> > > >> updated proposal
> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
> > > >>
> > > >> I'll start with my own +1.
> > > >>
> > > >> Thanks,
> > > >> Bill
> > > >>
> > > >
> > > >
> > > >
> > >
> > >
> >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> >
> > *github: <http://goog_969573159/>github.com/dongjinleekr
> > <http://github.com/dongjinleekr>linkedin:
> kr.linkedin.com/in/dongjinleekr
> > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > www.slideshare.net/dongjinleekr
> > <http://www.slideshare.net/dongjinleekr>*
> >
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by John Roesler <jo...@confluent.io>.
+1 (non-binding)
Thanks!
On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <do...@apache.org> wrote:
> Great improvements. +1. (Non-binding)
>
> On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > +1 (binding)
> >
> > -Matthias
> >
> > On 9/17/18 1:12 PM, Guozhang Wang wrote:
> > > +1 from me, thanks Bill !
> > >
> > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com>
> wrote:
> > >
> > >> All,
> > >>
> > >> I'd like to start the voting process for KIP-372. Here's the link to
> > the
> > >> updated proposal
> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
> > >>
> > >> I'll start with my own +1.
> > >>
> > >> Thanks,
> > >> Bill
> > >>
> > >
> > >
> > >
> >
> >
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
>
> *github: <http://goog_969573159/>github.com/dongjinleekr
> <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> www.slideshare.net/dongjinleekr
> <http://www.slideshare.net/dongjinleekr>*
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Dongjin Lee <do...@apache.org>.
Great improvements. +1. (Non-binding)
On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <ma...@confluent.io>
wrote:
> +1 (binding)
>
> -Matthias
>
> On 9/17/18 1:12 PM, Guozhang Wang wrote:
> > +1 from me, thanks Bill !
> >
> > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com> wrote:
> >
> >> All,
> >>
> >> I'd like to start the voting process for KIP-372. Here's the link to
> the
> >> updated proposal
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
> >>
> >> I'll start with my own +1.
> >>
> >> Thanks,
> >> Bill
> >>
> >
> >
> >
>
>
--
*Dongjin Lee*
*A hitchhiker in the mathematical world.*
*github: <http://goog_969573159/>github.com/dongjinleekr
<http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<http://kr.linkedin.com/in/dongjinleekr>slideshare:
www.slideshare.net/dongjinleekr
<http://www.slideshare.net/dongjinleekr>*
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1 (binding)
-Matthias
On 9/17/18 1:12 PM, Guozhang Wang wrote:
> +1 from me, thanks Bill !
>
> On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com> wrote:
>
>> All,
>>
>> I'd like to start the voting process for KIP-372. Here's the link to the
>> updated proposal
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
>>
>> I'll start with my own +1.
>>
>> Thanks,
>> Bill
>>
>
>
>
Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping
Posted by Guozhang Wang <wa...@gmail.com>.
+1 from me, thanks Bill !
On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bb...@gmail.com> wrote:
> All,
>
> I'd like to start the voting process for KIP-372. Here's the link to the
> updated proposal
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping
>
> I'll start with my own +1.
>
> Thanks,
> Bill
>
--
-- Guozhang