[GitHub] [maven-shared-utils] kwin commented on a diff in pull request #123: [MSHARED-1172] Deprecate redundant isEmptyString method

[GitBox <gi...@apache.org>]

kwin commented on code in PR #123:
URL: https://github.com/apache/maven-shared-utils/pull/123#discussion_r1059789127


##########
src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomUtils.java:
##########
@@ -148,15 +148,15 @@ private static boolean isMergeChildren( Xpp3Dom dominant )
     }
 
     /**
-     * @param str The string to be checked.
-     * @return <code>true</code> in case string is empty <code>false</code> otherwise.
+     * @deprecated use <code>str == null || String.isBlank(str)</code> (Java 11+) 

Review Comment:
   Why not recommending `https://github.com/apache/maven-shared-utils/blob/f4383c55f77ad4480f146481bf3192bc52c3af30/src/main/java/org/apache/maven/shared/utils/StringUtils.java#L145` as replacement? Or should we rather deprecate that method as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org