You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/11 20:49:11 UTC

[GitHub] [superset] betodealmeida commented on a change in pull request #18001: feat: shorter timeout on test_connection

betodealmeida commented on a change in pull request #18001:
URL: https://github.com/apache/superset/pull/18001#discussion_r782514331



##########
File path: superset/databases/commands/test_connection.py
##########
@@ -78,7 +81,24 @@ def run(self) -> None:
             )
             with closing(engine.raw_connection()) as conn:
                 try:
+                    alive = func_timeout(

Review comment:
       Ah, good point on the 408. Let me added it and add a test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org