You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/10/11 01:35:22 UTC
Review Request 26581: SQOOP-1156: HBase connector TO direction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs
-----
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/pom.xml e98a0fc
pom.xml f25a29f
server/pom.xml 67baaa5
test/pom.xml 7a80710
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57100
-----------------------------------------------------------
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97580>
Shall we close the connection explicitly?
https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HConnectionManager.html#createConnection(org.apache.hadoop.conf.Configuration)
>> his bypasses the usual HConnection life cycle management done by getConnection(Configuration). The caller is responsible for calling Connection.close() on the returned connection instance. This is the recommended way to create HConnections.
- Qian Xu
On Oct. 11, 2014, 7:35 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2014, 7:35 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 71
> > <https://reviews.apache.org/r/26581/diff/4/?file=791327#file791327line71>
> >
> > I had this same question in KiteConnector as well , do we need to createConnection every time?
>
> Veena Basavaraj wrote:
> looks like you chose not to do this for ease, but I wonder does this have any perf issue with so many calls to get connection
It probably will. I'd like to address this in a separate Jira because it's a big usage question. It'll probably require it's own context, similar to Repository.java#doWithConnection.
> On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java, line 48
> > <https://reviews.apache.org/r/26581/diff/4/?file=791328#file791328line48>
> >
> > is it ok for the loader to write JODA date time objects?
> >
> > Can we have more unit tests per data type on how it gets written ?
> >
> > Or is this something we will cover in integration tests?
There is only one data type for HBase: Binary.
Testing of types will be covered more extensively in integration tests.
> On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java, line 29
> > <https://reviews.apache.org/r/26581/diff/4/?file=791333#file791333line29>
> >
> > ditto: does not any of these have any validations? Ots ok if you want to address in a new ticket, please add that in
Jira: https://issues.apache.org/jira/browse/SQOOP-1928
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review65034
-----------------------------------------------------------
On Dec. 14, 2014, 12:26 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2014, 12:26 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml dfa7e88
> pom.xml efb9659
> server/pom.xml 77477ee
> test/pom.xml 35d36c1
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Dec. 13, 2014, 5:53 p.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java, line 48
> > <https://reviews.apache.org/r/26581/diff/4/?file=791328#file791328line48>
> >
> > is it ok for the loader to write JODA date time objects?
> >
> > Can we have more unit tests per data type on how it gets written ?
> >
> > Or is this something we will cover in integration tests?
>
> Abraham Elmahrek wrote:
> There is only one data type for HBase: Binary.
>
> Testing of types will be covered more extensively in integration tests.
fair will look forward to the test patch :)
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review65034
-----------------------------------------------------------
On Dec. 18, 2014, 1:46 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 1:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java PRE-CREATION
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java 98112e7
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java acdda6d
> connector/pom.xml dfa7e88
> pom.xml aa4231e
> server/pom.xml 77477ee
> test/pom.xml 38b2279
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Dec. 13, 2014, 5:53 p.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 71
> > <https://reviews.apache.org/r/26581/diff/4/?file=791327#file791327line71>
> >
> > I had this same question in KiteConnector as well , do we need to createConnection every time?
looks like you chose not to do this for ease, but I wonder does this have any perf issue with so many calls to get connection
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review65034
-----------------------------------------------------------
On Dec. 13, 2014, 4:26 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2014, 4:26 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml dfa7e88
> pom.xml efb9659
> server/pom.xml 77477ee
> test/pom.xml 35d36c1
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review65034
-----------------------------------------------------------
Overall looks great. Please address the comments below and I am glag there is a separate ticket for the integration tests to use Hbase as a TO connector.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
<https://reviews.apache.org/r/26581/#comment107965>
Please add a few comments / java doc, will be educative for someone reading this code.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment107966>
I had this same question in KiteConnector as well , do we need to createConnection every time?
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
<https://reviews.apache.org/r/26581/#comment107972>
is it ok for the loader to write JODA date time objects?
Can we have more unit tests per data type on how it gets written ?
Or is this something we will cover in integration tests?
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
<https://reviews.apache.org/r/26581/#comment107967>
Please remove these TODOs. if you want to fix this create a ticket, else add a NOTE describing the limitation
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
<https://reviews.apache.org/r/26581/#comment107968>
There is a JarUtil in the connector-sdk, might be good to see if that helps, or move this code to the util so that other conenctors can use, every connector is hacking how the dependend jars are laoded, as Qian says
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
<https://reviews.apache.org/r/26581/#comment107969>
just use the NullSchema, if there is no schema, you can drop overriding this method completelt.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
<https://reviews.apache.org/r/26581/#comment107970>
are there no validations for this field?
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
<https://reviews.apache.org/r/26581/#comment107971>
ditto: does not any of these have any validations? Ots ok if you want to address in a new ticket, please add that in
- Veena Basavaraj
On Dec. 13, 2014, 4:26 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2014, 4:26 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml dfa7e88
> pom.xml efb9659
> server/pom.xml 77477ee
> test/pom.xml 35d36c1
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review65555
-----------------------------------------------------------
Ship it!
Ship It!
- Veena Basavaraj
On Dec. 18, 2014, 1:46 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 1:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java PRE-CREATION
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java 98112e7
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java acdda6d
> connector/pom.xml dfa7e88
> pom.xml aa4231e
> server/pom.xml 77477ee
> test/pom.xml 38b2279
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated March 17, 2015, 5:28 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs
-----
common/src/main/java/org/apache/sqoop/validation/validators/PortOrNull.java PRE-CREATION
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/asserts/HBaseAsserts.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/hbase-connector-config.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java e3068f0
connector/pom.xml dfa7e88
pom.xml 32afc77
server/pom.xml ee409cb
test/pom.xml f743d25
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
test/src/main/java/org/apache/sqoop/test/testcases/HBaseConnectorTestCase.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hbase/FromRDBMSToHBaseTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26581/diff/
Testing (updated)
-------
mvn clean verify + can transfer from mysql to hbase.
Added integration test case.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated March 17, 2015, 5:27 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/validation/validators/PortOrNull.java PRE-CREATION
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/asserts/HBaseAsserts.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/hbase-connector-config.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java e3068f0
connector/pom.xml dfa7e88
pom.xml 32afc77
server/pom.xml ee409cb
test/pom.xml f743d25
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
test/src/main/java/org/apache/sqoop/test/testcases/HBaseConnectorTestCase.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/connector/hbase/FromRDBMSToHBaseTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 9:46 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java PRE-CREATION
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java 98112e7
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java acdda6d
connector/pom.xml dfa7e88
pom.xml aa4231e
server/pom.xml 77477ee
test/pom.xml 38b2279
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated Dec. 14, 2014, 12:26 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs (updated)
-----
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/pom.xml dfa7e88
pom.xml efb9659
server/pom.xml 77477ee
test/pom.xml 35d36c1
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 2:34 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs (updated)
-----
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/pom.xml e98a0fc
pom.xml 3449a6f
server/pom.xml be2ee9b
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9a81832
server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 0e2e176
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java d249d6c
test/pom.xml 956aeb7
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 3da0693
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java b1b3b16
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java e482ac5
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 824a51d
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f42fa32
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 055bc3d
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Jarek Cecho <ja...@apache.org>.
> On Oct. 17, 2014, 8:45 a.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java, line 96
> > <https://reviews.apache.org/r/26581/diff/2/?file=724138#file724138line96>
> >
> > I'm facing a similar situation for Kite connector. How about
> >
> > `
> > @Override
> > public List<String> getJars(InitializerContext context,
> > LinkConfiguration link, ToJobConfiguration job) {
> > List<String> jars = super.getJars(context, link, job);
> >
> > addDesiredJars(jars, ((URLClassLoader) Thread.currentThread().getContextClassLoader()));
> >
> > return jars;
> > }
> >
> > private void addDesiredJars(List<String> jars, URLClassLoader loader) {
> > for (URL url : loader.getURLs()) {
> > String path = url.getPath();
> > if (path.endsWith(".jar") && !jars.contains(url.getFile())) {
> > jars.add(url.toString());
> > }
> > }
> > }
> > `
>
> Qian Xu wrote:
> `private static void addDesiredJars(...`
>
> Qian Xu wrote:
> I'm think why these jars are not submitted together with MR job by default?
I did not yet reviewed entire code, so I'm just responding to this note :)
1) We are not shipping entire Sqoop Server classpath to the mapreduce because there is no good reason why to do that and there is plenty of reasons why not to do that. Albeit make it easy for connector developer is not one of them :) Server have on the classpath jars for all connectors, entire functionality and even Hadoop. That can be several megabytes worth of jars that we would transfer to each and every node in the cluster for every single mapreduce job. That is huge waste of resources. E.g. why would be shipping Tomcat jars to MR? Or HBase jars where there is no HBase involved? Why would we ship hadoop jars when Hadoop is by definition on the MR job classpath already?
2) If you look how other projects are dealing with that you'll found that most of them are exposing methods that will return list of jars that is actually required. For example HBase:
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java#L736
That downstream components are using. For example Pig:
https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java#L751
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57123
-----------------------------------------------------------
On Oct. 17, 2014, 6:37 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 6:37 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
> On Oct. 17, 2014, 4:45 p.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java, line 96
> > <https://reviews.apache.org/r/26581/diff/2/?file=724138#file724138line96>
> >
> > I'm facing a similar situation for Kite connector. How about
> >
> > `
> > @Override
> > public List<String> getJars(InitializerContext context,
> > LinkConfiguration link, ToJobConfiguration job) {
> > List<String> jars = super.getJars(context, link, job);
> >
> > addDesiredJars(jars, ((URLClassLoader) Thread.currentThread().getContextClassLoader()));
> >
> > return jars;
> > }
> >
> > private void addDesiredJars(List<String> jars, URLClassLoader loader) {
> > for (URL url : loader.getURLs()) {
> > String path = url.getPath();
> > if (path.endsWith(".jar") && !jars.contains(url.getFile())) {
> > jars.add(url.toString());
> > }
> > }
> > }
> > `
>
> Qian Xu wrote:
> `private static void addDesiredJars(...`
I'm think why these jars are not submitted together with MR job by default?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57123
-----------------------------------------------------------
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
> On Oct. 17, 2014, 4:45 p.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java, line 96
> > <https://reviews.apache.org/r/26581/diff/2/?file=724138#file724138line96>
> >
> > I'm facing a similar situation for Kite connector. How about
> >
> > `
> > @Override
> > public List<String> getJars(InitializerContext context,
> > LinkConfiguration link, ToJobConfiguration job) {
> > List<String> jars = super.getJars(context, link, job);
> >
> > addDesiredJars(jars, ((URLClassLoader) Thread.currentThread().getContextClassLoader()));
> >
> > return jars;
> > }
> >
> > private void addDesiredJars(List<String> jars, URLClassLoader loader) {
> > for (URL url : loader.getURLs()) {
> > String path = url.getPath();
> > if (path.endsWith(".jar") && !jars.contains(url.getFile())) {
> > jars.add(url.toString());
> > }
> > }
> > }
> > `
`private static void addDesiredJars(...`
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57123
-----------------------------------------------------------
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57123
-----------------------------------------------------------
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
<https://reviews.apache.org/r/26581/#comment97597>
I'm facing a similar situation for Kite connector. How about
`
@Override
public List<String> getJars(InitializerContext context,
LinkConfiguration link, ToJobConfiguration job) {
List<String> jars = super.getJars(context, link, job);
addDesiredJars(jars, ((URLClassLoader) Thread.currentThread().getContextClassLoader()));
return jars;
}
private void addDesiredJars(List<String> jars, URLClassLoader loader) {
for (URL url : loader.getURLs()) {
String path = url.getPath();
if (path.endsWith(".jar") && !jars.contains(url.getFile())) {
jars.add(url.toString());
}
}
}
`
- Qian Xu
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 19, 2014, 6:27 p.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java, line 32
> > <https://reviews.apache.org/r/26581/diff/2/?file=724136#file724136line32>
> >
> > nitpick
> > we can have default access for methods used in testing only, it does not need to be protected.
> >
> > Only trick is of course have the test in the same package. Please remove protected
>
> Abraham Elmahrek wrote:
> Hmm protected scope is on purpose. This forces test case writers to extend this class and override these methods. What test purpose does package scope serve?
you dont need protected if you have access this in the test class only.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57303
-----------------------------------------------------------
On Nov. 7, 2014, 6:34 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 6:34 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml 3449a6f
> server/pom.xml be2ee9b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9a81832
> server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 0e2e176
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java d249d6c
> test/pom.xml 956aeb7
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 3da0693
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java b1b3b16
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java e482ac5
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 824a51d
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f42fa32
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 055bc3d
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java, line 24
> > <https://reviews.apache.org/r/26581/diff/2/?file=724133#file724133line24>
> >
> > a thought. why we have Errorcode has a interface, can we just make it class and make it simple for developers not to have to duplicate this in every conenctor?
> >
> > private final String message;
> > 40
> > 41
> > private HBaseConnectorError(String message) {
> > 42
> > this.message = message;
> > 43
> > }
> > 44
> > 45
> > public String getCode() {
> > 46
> > return name();
> > 47
> > }
> > 48
> > 49
> > public String getMessage() {
> > 50
> > return message;
> > 51
> > }
Possibly. Addressable in a separate Jira.
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 52
> > <https://reviews.apache.org/r/26581/diff/2/?file=724135#file724135line52>
> >
> > are not these configs values a must?
> >
> > if the answer is yes, they are required.
> > can we not throw an exception right here?
> >
> > Or is this checked in validators.
> >
> > I have not seen a way yet that enforces required/ optiona. Might be a good annotation feature to have
Hmm like Preconditions for methods? In general seems like a good idea. Not implemented yet though, so let's log a ticket and do it later?
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 71
> > <https://reviews.apache.org/r/26581/diff/2/?file=724135#file724135line71>
> >
> > I am curious if we can store the connection here. Do we need to create a new one evertime we call getTables, getColumnFamilies? why cant we reuse?
> >
> > I might be missing something, but I felt it is worth asking
I wanted to make the executor self contained. By sharing a connection, we will have to close the connection outside of the executor. Or, we'll have to add "start" and "stop" methods to the executor. This seemed easier.
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 108
> > <https://reviews.apache.org/r/26581/diff/2/?file=724135#file724135line108>
> >
> > its nice to use Apache common StringUtils in cases like this for length and null check.
This is an array of HColumnDescriptor?
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 111
> > <https://reviews.apache.org/r/26581/diff/2/?file=724135#file724135line111>
> >
> > http://stackoverflow.com/questions/3052442/what-is-the-difference-between-text-and-new-stringtext-in-java
> >
> > new String is a overkill :)
``getName()`` returns an array of bytes.
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java, line 32
> > <https://reviews.apache.org/r/26581/diff/2/?file=724136#file724136line32>
> >
> > nitpick
> > we can have default access for methods used in testing only, it does not need to be protected.
> >
> > Only trick is of course have the test in the same package. Please remove protected
Hmm protected scope is on purpose. This forces test case writers to extend this class and override these methods. What test purpose does package scope serve?
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java, line 31
> > <https://reviews.apache.org/r/26581/diff/2/?file=724137#file724137line31>
> >
> > This seems like a case where we could provide a common abstract class for connector developers, they just need not even add this class, since there is nothing they are even doing.
Agreed. Future Jiras.
> On Oct. 20, 2014, 1:27 a.m., Veena Basavaraj wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java, line 33
> > <https://reviews.apache.org/r/26581/diff/2/?file=724140#file724140line33>
> >
> > Please see if we can move these classes to connecto sdk so we can reuse them across all connectors.? Since I dont see any specific config validators either
> >
> > Again some of these comments are not related to HBase, but in general reducing the burden for connector developers.
Let's address generalizations in future jiras?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57303
-----------------------------------------------------------
On Oct. 17, 2014, 6:37 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 6:37 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57303
-----------------------------------------------------------
Nice feature. Have tons of comments. Please feel free to ping me in person if you need clarifications.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
<https://reviews.apache.org/r/26581/#comment97952>
Please remove todo: seems ok to have a exception until we add support for FROM
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
<https://reviews.apache.org/r/26581/#comment97953>
same as above
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
<https://reviews.apache.org/r/26581/#comment97954>
heads up : upgrade api has changed.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
<https://reviews.apache.org/r/26581/#comment97955>
please call this configs, helps to be consistent with other 2 conenctors and more readable.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
<https://reviews.apache.org/r/26581/#comment97956>
a thought. why we have Errorcode has a interface, can we just make it class and make it simple for developers not to have to duplicate this in every conenctor?
private final String message;
40
41
private HBaseConnectorError(String message) {
42
this.message = message;
43
}
44
45
public String getCode() {
46
return name();
47
}
48
49
public String getMessage() {
50
return message;
51
}
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
<https://reviews.apache.org/r/26581/#comment97947>
Please see the latest code, the api has changed. There is util class to avoid the copy paste.
I ahve refactored common logic used by all configurables to a util class
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97957>
nice annotation. I did not know this:)
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97958>
are not these configs values a must?
if the answer is yes, they are required.
can we not throw an exception right here?
Or is this checked in validators.
I have not seen a way yet that enforces required/ optiona. Might be a good annotation feature to have
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97962>
I am curious if we can store the connection here. Do we need to create a new one evertime we call getTables, getColumnFamilies? why cant we reuse?
I might be missing something, but I felt it is worth asking
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97959>
its nice to use Apache common StringUtils in cases like this for length and null check.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97960>
http://stackoverflow.com/questions/3052442/what-is-the-difference-between-text-and-new-stringtext-in-java
new String is a overkill :)
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97961>
can see many cases of NPE here. I hope the unit tests cover it.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
<https://reviews.apache.org/r/26581/#comment97963>
nitpick
we can have default access for methods used in testing only, it does not need to be protected.
Only trick is of course have the test in the same package. Please remove protected
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
<https://reviews.apache.org/r/26581/#comment97964>
This seems like a case where we could provide a common abstract class for connector developers, they just need not even add this class, since there is nothing they are even doing.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
<https://reviews.apache.org/r/26581/#comment97965>
please use linkConfig, LinkConfig and Link are 2 different things, just makes code much readable .
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
<https://reviews.apache.org/r/26581/#comment97948>
nit pick, can this be renamed to linkConfig.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
<https://reviews.apache.org/r/26581/#comment97966>
Please see if we can move these classes to connecto sdk so we can reuse them across all connectors.? Since I dont see any specific config validators either
Again some of these comments are not related to HBase, but in general reducing the burden for connector developers.
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
<https://reviews.apache.org/r/26581/#comment97949>
toTable, please rename might be a artifact of c&p
connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
<https://reviews.apache.org/r/26581/#comment97950>
Please cleanup usages of forms to configs and would be nice to have linkConfig, toJobConfig and fromJobConfig as the properties.
Also, to be consistent with other 2 connectors, kindly request you rename this to *configs.properties
connector/connector-hbase/src/main/resources/sqoopconnector.properties
<https://reviews.apache.org/r/26581/#comment97951>
JDBC? please fix the comment
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
<https://reviews.apache.org/r/26581/#comment97967>
call it HBaseExecutor, please.
Consistent naming helps.
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
<https://reviews.apache.org/r/26581/#comment97968>
nit pick, suffixing with mock, makes code redable as well.
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
<https://reviews.apache.org/r/26581/#comment97969>
is this intentional to have extractor table in the test loader ?
- Veena Basavaraj
On Oct. 16, 2014, 11:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 11:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
> On Oct. 17, 2014, 2:55 p.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 62
> > <https://reviews.apache.org/r/26581/diff/1-2/?file=718066#file718066line62>
> >
> > How about considering the deprecation suggestion?
> >
> > > Constructing HBaseAdmin objects manually has been deprecated. Use Connection.getAdmin() to obtain an instance of Admin instead.
>
> Abraham Elmahrek wrote:
> I'm not 100% sure on this one: https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HConnection.html. `HConnection.getAdmin` seems deprecated. It seems like the APIs are in the process of changing. Let's keep this for now since the API isn't deprecated in the latest stable release (https://github.com/apache/hbase/blob/0.99.1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java#L195)?
Okay, then no change is required. Note that I'm not sure if creating `HBaseAdmin` too frequently will leak memory. I'd once massive memory leaks on production environment 20 days after service startup. Leaks were caused in `admin.close()`. Internal reference counting was not decremented. Do not remember if the hbase jars are the original or home made.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57115
-----------------------------------------------------------
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 17, 2014, 6:55 a.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, line 62
> > <https://reviews.apache.org/r/26581/diff/1-2/?file=718066#file718066line62>
> >
> > How about considering the deprecation suggestion?
> >
> > > Constructing HBaseAdmin objects manually has been deprecated. Use Connection.getAdmin() to obtain an instance of Admin instead.
I'm not 100% sure on this one: https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HConnection.html. `HConnection.getAdmin` seems deprecated. It seems like the APIs are in the process of changing. Let's keep this for now since the API isn't deprecated in the latest stable release (https://github.com/apache/hbase/blob/0.99.1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java#L195)?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57115
-----------------------------------------------------------
On Oct. 17, 2014, 6:37 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 6:37 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57115
-----------------------------------------------------------
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
<https://reviews.apache.org/r/26581/#comment97593>
How about considering the deprecation suggestion?
> Constructing HBaseAdmin objects manually has been deprecated. Use Connection.getAdmin() to obtain an instance of Admin instead.
- Qian Xu
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26581: SQOOP-1156: HBase connector TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 6:37 a.m.)
Review request for Sqoop.
Changes
-------
Incorporated Qian's feedback
Bugs: SQOOP-1156
https://issues.apache.org/jira/browse/SQOOP-1156
Repository: sqoop-sqoop2
Description
-------
commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 9 22:56:34 2014 -0700
SQOOP-1156: HBase connector
:000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M connector/pom.xml
:100644 100644 f25a29f... a556bcf... M pom.xml
:100644 100644 67baaa5... 21a1fa9... M server/pom.xml
:100644 100644 7a80710... fbd4e84... M test/pom.xml
Diffs (updated)
-----
connector/connector-hbase/pom.xml PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION
connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION
connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION
connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION
connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
connector/pom.xml e98a0fc
pom.xml f25a29f
server/pom.xml 67baaa5
test/pom.xml 7a80710
Diff: https://reviews.apache.org/r/26581/diff/
Testing
-------
mvn clean verify + can transfer from mysql to hbase.
Thanks,
Abraham Elmahrek