You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Venkatesan Ramachandran <me...@gmail.com> on 2016/02/02 07:38:32 UTC

Review Request 43085: FALCON-1806 : Documentation for Import and Export

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/
-----------------------------------------------------------

Review request for Falcon and Pallavi Rao.


Repository: falcon-git


Description
-------

Documentation for Import and Export


Diffs
-----

  docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
  docs/src/site/twiki/ImportExport.twiki PRE-CREATION 

Diff: https://reviews.apache.org/r/43085/diff/


Testing
-------


Thanks,

Venkatesan Ramachandran


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117383
-----------------------------------------------------------


Ship it!




Ship It!

- Ajay Yadava


On Feb. 2, 2016, 6:38 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 6:38 a.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117374
-----------------------------------------------------------


Ship it!




Ship It!

- Pallavi Rao


On Feb. 2, 2016, 6:38 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 6:38 a.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117893
-----------------------------------------------------------


Ship it!




Ship It!

- Balu Vellanki


On Feb. 2, 2016, 8:25 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:25 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> + Added supported combination of extraction and organization types.
> + Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117613
-----------------------------------------------------------


Ship it!




Ship It!

- Peeyush Bishnoi


On Feb. 2, 2016, 8:25 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:25 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> + Added supported combination of extraction and organization types.
> + Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Venkatesan Ramachandran <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 8:25 p.m.)


Review request for Falcon and Pallavi Rao.


Changes
-------

Documentation for Import and Export for 0.10 release


Repository: falcon-git


Description (updated)
-------

+ Added supported combination of extraction and organization types.
+ Documentation for Import and Export


Diffs (updated)
-----

  docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
  docs/src/site/twiki/ImportExport.twiki PRE-CREATION 

Diff: https://reviews.apache.org/r/43085/diff/


Testing
-------


Thanks,

Venkatesan Ramachandran


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Ajay Yadava <aj...@gmail.com>.

> On Feb. 2, 2016, 8:59 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/ImportExport.twiki, line 180
> > <https://reviews.apache.org/r/43085/diff/1/?file=1229042#file1229042line180>
> >
> >     This gives rise to an issue, if user submits for incremental, are we throwing appropriate validation error?
> 
> Venkatesan Ramachandran wrote:
>     I have updated the docs with the supported combination of extraction and organization types. Currently, incremental extraction + append is supported,
> 
> Ajay Yadava wrote:
>     Do you think it will be better to throw some "Unsupported operation" type error in validation? This is the general approach that we have been taking in Falcon.
> 
> Venkatesan Ramachandran wrote:
>     Currently Feed entity validation throws ValidationException saying it's not supported.

Thanks, that is exactly what I wanted to confirm.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117384
-----------------------------------------------------------


On Feb. 2, 2016, 8:25 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:25 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> + Added supported combination of extraction and organization types.
> + Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Venkatesan Ramachandran <me...@gmail.com>.

> On Feb. 2, 2016, 8:59 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/ImportExport.twiki, line 180
> > <https://reviews.apache.org/r/43085/diff/1/?file=1229042#file1229042line180>
> >
> >     This gives rise to an issue, if user submits for incremental, are we throwing appropriate validation error?

I have updated the docs with the supported combination of extraction and organization types. Currently, incremental extraction + append is supported,


- Venkatesan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117384
-----------------------------------------------------------


On Feb. 2, 2016, 6:38 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 6:38 a.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Ajay Yadava <aj...@gmail.com>.

> On Feb. 2, 2016, 8:59 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/ImportExport.twiki, line 180
> > <https://reviews.apache.org/r/43085/diff/1/?file=1229042#file1229042line180>
> >
> >     This gives rise to an issue, if user submits for incremental, are we throwing appropriate validation error?
> 
> Venkatesan Ramachandran wrote:
>     I have updated the docs with the supported combination of extraction and organization types. Currently, incremental extraction + append is supported,

Do you think it will be better to throw some "Unsupported operation" type error in validation? This is the general approach that we have been taking in Falcon.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117384
-----------------------------------------------------------


On Feb. 2, 2016, 8:25 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:25 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> + Added supported combination of extraction and organization types.
> + Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Venkatesan Ramachandran <me...@gmail.com>.

> On Feb. 2, 2016, 8:59 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/ImportExport.twiki, line 180
> > <https://reviews.apache.org/r/43085/diff/1/?file=1229042#file1229042line180>
> >
> >     This gives rise to an issue, if user submits for incremental, are we throwing appropriate validation error?
> 
> Venkatesan Ramachandran wrote:
>     I have updated the docs with the supported combination of extraction and organization types. Currently, incremental extraction + append is supported,
> 
> Ajay Yadava wrote:
>     Do you think it will be better to throw some "Unsupported operation" type error in validation? This is the general approach that we have been taking in Falcon.

Currently Feed entity validation throws ValidationException saying it's not supported.


- Venkatesan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117384
-----------------------------------------------------------


On Feb. 2, 2016, 8:25 p.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:25 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> + Added supported combination of extraction and organization types.
> + Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>


Re: Review Request 43085: FALCON-1806 : Documentation for Import and Export

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43085/#review117384
-----------------------------------------------------------




docs/src/site/twiki/ImportExport.twiki (line 180)
<https://reviews.apache.org/r/43085/#comment178539>

    This gives rise to an issue, if user submits for incremental, are we throwing appropriate validation error?


- Ajay Yadava


On Feb. 2, 2016, 6:38 a.m., Venkatesan Ramachandran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43085/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 6:38 a.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for Import and Export
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/FalconDocumentation.twiki 21b22ff 
>   docs/src/site/twiki/ImportExport.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>