[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11640: fix: Title change made in Edit Chart Properties is not showing on the title

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11640:
URL: https://github.com/apache/incubator-superset/pull/11640#discussion_r523814651



##########
File path: superset-frontend/src/explore/components/SaveModal.jsx
##########
@@ -109,19 +110,31 @@ class SaveModal extends React.Component {
     sliceParams.save_to_dashboard_id = this.state.saveToDashboardId;
     sliceParams.new_dashboard_name = this.state.newDashboardName;
 
-    this.props.actions
-      .saveSlice(this.props.form_data, sliceParams)
-      .then(({ data }) => {
-        if (data.dashboard_id === null) {
-          sessionStorage.removeItem(SK_DASHBOARD_ID);
-        } else {
-          sessionStorage.setItem(SK_DASHBOARD_ID, data.dashboard_id);
-        }
-        // Go to new slice url or dashboard url
-        const url = gotodash ? data.dashboard_url : data.slice.slice_url;
-        window.location.assign(url);
+    if (slice.slice_updated) {
+      const payload = {
+        description: slice.description || null,
+        cache_timeout: slice.cache_timeout || null,
+        owners: slice.owners || null,
+      };
+      await SupersetClient.put({

Review comment:
       Personally I think an "Ok" button that affects the redux store is the way to go, and a single "Save" api call later on that saves the whole thing. Similarly, using the editable click-on-title should only affect the redux store.
   
   Do we still need the "Edit Chart Properties" from any other contexts like the Chart list view? I don't think so. I'd just rip that out and assume that people have to go to the explore view if they want to edit the properties of a chart.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org