You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/06/20 07:32:22 UTC
[shardingsphere] branch master updated: Little optimize. (#26451)
This is an automated email from the ASF dual-hosted git repository.
zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 30a422542fa Little optimize. (#26451)
30a422542fa is described below
commit 30a422542fa6ab9a3861f0e0268fae38e462188a
Author: Chuxin Chen <ch...@qq.com>
AuthorDate: Tue Jun 20 15:32:12 2023 +0800
Little optimize. (#26451)
---
.../ddlgenerator/PostgreSQLColumnPropertiesAppender.java | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ddlgenerator/PostgreSQLColumnPropertiesAppender.java b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ddlgenerator/PostgreSQLColumnPropertiesAppender.java
index 464d2d6bc9c..01824305842 100644
--- a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ddlgenerator/PostgreSQLColumnPropertiesAppender.java
+++ b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ddlgenerator/PostgreSQLColumnPropertiesAppender.java
@@ -204,8 +204,6 @@ public final class PostgreSQLColumnPropertiesAppender extends AbstractPostgreSQL
String typeName = (String) column.get("typname");
Integer numdims = (Integer) column.get("attndims");
String schema = null != namespace ? namespace : "";
- String array = "";
- String length = "";
String name = checkSchemaInName(typeName, schema);
if (name.startsWith("_")) {
if (null == numdims || 0 == numdims) {
@@ -222,14 +220,9 @@ public final class PostgreSQLColumnPropertiesAppender extends AbstractPostgreSQL
if (name.startsWith("\"") && name.endsWith("\"")) {
name = name.substring(1, name.length() - 1);
}
- if (numdims == 1) {
- array = "[]";
- }
Integer typmod = (Integer) column.get("atttypmod");
- if (-1 != typmod) {
- length = checkTypmod(typmod, name);
- }
- return getFullTypeValue(name, schema, length, array);
+ String length = -1 != typmod ? checkTypmod(typmod, name) : "";
+ return getFullTypeValue(name, schema, length, numdims == 1 ? "[]" : "");
}
private String checkSchemaInName(final String typname, final String schema) {