You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "akalash (via GitHub)" <gi...@apache.org> on 2023/04/20 14:04:23 UTC

[GitHub] [flink] akalash opened a new pull request, #22436: [FLINK-30852][runtime] Checking task cancelation explicitly rather th…

akalash opened a new pull request, #22436:
URL: https://github.com/apache/flink/pull/22436

   …an failing the cancel method
   
   (cherry picked from commit a6f0165c09b7f276f1e755ba46c7f15bf4f21c92)
   
   
   ## What is the purpose of the change
   
   It is backport of #21833 
   
   
   ## Brief change log
   
   
   -     Explicit assert for the task cancelation in tests
   -     Removed the exception from TestInvokableCorrect#cancel since in some test it isn't correct
   
   
   ## Verifying this change
   It's test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22436: [FLINK-30852][runtime] Checking task cancelation explicitly rather th…

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22436:
URL: https://github.com/apache/flink/pull/22436#issuecomment-1516406424

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ac8cdebc0e478e3bb4d82d1052f2e8bbc547d2fc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac8cdebc0e478e3bb4d82d1052f2e8bbc547d2fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac8cdebc0e478e3bb4d82d1052f2e8bbc547d2fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] akalash merged pull request #22436: [FLINK-30852][runtime] Checking task cancelation explicitly rather th…

Posted by "akalash (via GitHub)" <gi...@apache.org>.
akalash merged PR #22436:
URL: https://github.com/apache/flink/pull/22436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org