You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/08/31 07:57:11 UTC
[jira] [Created] (HBASE-4309) slow query log metrics spewing
warnings
slow query log metrics spewing warnings
---------------------------------------
Key: HBASE-4309
URL: https://issues.apache.org/jira/browse/HBASE-4309
Project: HBase
Issue Type: Bug
Components: metrics
Affects Versions: 0.92.0
Reporter: Todd Lipcon
Assignee: Riley Patterson
Priority: Critical
Fix For: 0.92.0
Lots of these in the logs in trunk:
2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Riley Patterson updated HBASE-4309:
-----------------------------------
Attachment: HBASE-4309-alternative.patch
An alternative patch in case there is any hesitation about changes made in the first one. This one merely comments out the two offending metrics, adding TODOs to fix them properly, and fixes the index out of bounds bug.
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309-alternative.patch, HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094377#comment-13094377 ]
Riley Patterson commented on HBASE-4309:
----------------------------------------
Attached a quickly put-together patch. If the changes to HBaseRpcMetrics in this patch are at all controversial, consider the alternative patch for now; it just comments out the metrics and adds TODOs. Note that in these patches I also fix one other small bug (array index out of bounds) that we found internally this evening.
I apologize for this. Some bugs slipped into small changes made after my thorough testing. I'll be more careful in the future.
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309-alternative.patch, HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099163#comment-13099163 ]
Hudson commented on HBASE-4309:
-------------------------------
Integrated in HBase-TRUNK #2182 (See [https://builds.apache.org/job/HBase-TRUNK/2182/])
HBASE-4309 slow query log metrics spewing warnings
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309-alternative.patch, HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Riley Patterson updated HBASE-4309:
-----------------------------------
Attachment: HBASE-4309-alternative.patch
An alternative patch in case there is any hesitation about changes made in the first one. This one merely comments out the two offending metrics, adding TODOs to fix them properly, and fixes the index out of bounds bug.
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4309.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Applied the more adventurous patch. Will revert to the alternative if gives us grief. Thanks for patch Riley.
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309-alternative.patch, HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Riley Patterson updated HBASE-4309:
-----------------------------------
Attachment: (was: HBASE-4309-alternative.patch)
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4309) slow query log metrics spewing
warnings
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Riley Patterson updated HBASE-4309:
-----------------------------------
Attachment: HBASE-4309.patch
Enables proper use of HBaseRpcMetrics for the metrics added in HBASE-4117 (slow query log)
> slow query log metrics spewing warnings
> ---------------------------------------
>
> Key: HBASE-4309
> URL: https://issues.apache.org/jira/browse/HBASE-4309
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Riley Patterson
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4309.patch
>
>
> Lots of these in the logs in trunk:
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.slowResponse.
> 2011-08-30 22:54:36,100 WARN org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Got inc() request for method that doesnt exist: get.aboveOneSec.
> ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira