You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/07 05:13:16 UTC

[GitHub] [hive] ayushtkn commented on a change in pull request #2950: HIVE-25872: Skip tracking of alterDatabase events for replication specific properties

ayushtkn commented on a change in pull request #2950:
URL: https://github.com/apache/hive/pull/2950#discussion_r800320118



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -1613,6 +1618,30 @@ public void alter_database(final String dbName, final Database newDB) throws TEx
     }
   }
 
+  private boolean isAlterReplSpecific(Database oldDb, Database newDb) {

Review comment:
       Requires a rebase. Seems there is some similar logic in ``isReplicationEventIdUpdate`` see if you can refactor and reuse some part of it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org