You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2026/09/15 02:49:17 UTC

[PR] fix(runtime-host): publish admission before execution imports [maka]

liugddx opened a new pull request, #5325:
URL: https://github.com/apache/maka/pull/5325

   ## Summary
   
   Runtime Host candidates load the entire execution composition before owner election and Local IPC admission. Slow imports therefore leave the candidate undiscoverable, losing candidates load execution dependencies unnecessarily, and import failures escape candidate startup handling. Defer that import until the kernel has published its listener; preserve a bounded failure phase and errno in election diagnostics, and make the connection-timeout message describe an unavailable endpoint.
   
   Fixes #5324. The issue includes the triggering Windows nightly report and a controlled reproduction; this PR does not claim to establish the sole cause of that historical 45-second timeout or increase the default deadline.
   
   ## Verification
   
   - Runtime Host TypeScript project build and diff checks passed. Repository-wide Biome lint (3,592 files) and format (2,122 files) passed on the submission branch. The submission is based on current `main`; the affected package sources and manifests are identical to the validated checkout.
   - 18 targeted tests passed: candidate entry/factory, startup error copy, owner election/recovery/errno propagation, and clean/unexpected candidate exits.
   - The new import-order regression fails against the original factory (registration absent, unclassified exit 1) and passes with this change (listener reachable before import; failures handled; losing candidate skips execution imports).
   - Full execution Host smoke on Windows 10.0.19042, Node 22.23.1: fresh temporary root ready in ~7.7 seconds under the normal 45-second budget; subsequent clean exit 0.
   - Known baseline failure: `owned connection keeps a fresh Host alive for its full election window` times out under its 6-second budget on this machine, with both the original and changed factory. Its timeout was not relaxed. Full repository build/test/typecheck and desktop/UI Knip were not run; the all-suites checklist remains unchecked.
   - Staged ASF/protocol guards passed. The staged Biome checker was invoked with the native executable because its default Windows `.cmd` spawn returns EINVAL.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex investigated the report, implemented the changes and regression tests, ran local validation, and prepared this submission. The commit includes a `Generated-by: OpenAI Codex` trailer.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [ ] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(runtime-host): publish admission before execution imports [maka]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx merged PR #5325:
URL: https://github.com/apache/maka/pull/5325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org