[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #516: [Sedona-28] shape&wkb ser de

[GitBox <gi...@apache.org>]

jiayuasu commented on a change in pull request #516:
URL: https://github.com/apache/incubator-sedona/pull/516#discussion_r613636517



##########
File path: core/src/test/java/org/apache/sedona/core/serde/SedonaKryoRegistratorTest.java
##########
@@ -0,0 +1,55 @@
+package org.apache.sedona.core.serde;
+
+import com.esotericsoftware.kryo.Kryo;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+import org.apache.sedona.core.TestBase;
+import org.apache.sedona.core.serde.shape.ShapeGeometrySerde;
+import org.apache.sedona.core.serde.spatialindex.SpatialIndexSerde;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+import org.apache.spark.serializer.KryoSerializer;
+import org.junit.*;
+import org.locationtech.jts.geom.Point;
+
+import static org.junit.Assert.assertEquals;
+
+@Ignore
+public class SedonaKryoRegistratorTest extends TestBase {
+
+    public static JavaSparkContext sc;
+    public static SparkConf conf;
+
+    @BeforeClass
+    public static void onceExecutedBeforeAll()
+    {
+        conf = new SparkConf()
+                .setAppName(SedonaKryoRegistratorTest.class.getName())
+                .setMaster("local[2]")

Review comment:
       Fix this with the "initialize" example I mentioned.

##########
File path: core/src/test/java/org/apache/sedona/core/serde/SedonaWKBKryoRegistratorTest.java
##########
@@ -0,0 +1,56 @@
+package org.apache.sedona.core.serde;
+
+import com.esotericsoftware.kryo.Kryo;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+import org.apache.sedona.core.TestBase;
+import org.apache.sedona.core.serde.WKB.WKBGeometrySerde;
+import org.apache.sedona.core.serde.spatialindex.SpatialIndexSerde;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+import org.apache.spark.serializer.KryoSerializer;
+import org.junit.*;
+import org.locationtech.jts.geom.Point;
+
+import static org.junit.Assert.assertEquals;
+
+@Ignore
+public class SedonaWKBKryoRegistratorTest extends TestBase {
+
+    public static JavaSparkContext sc;
+    public static SparkConf conf;
+
+    @BeforeClass
+    public static void onceExecutedBeforeAll()
+    {
+        conf = new SparkConf()
+                .setAppName(SedonaWKBKryoRegistratorTest.class.getName())
+                .setMaster("local[2]")

Review comment:
       Fix this as well.

##########
File path: .github/workflows/java.yml
##########
@@ -41,6 +41,7 @@ jobs:
     - env:
         SPARK_VERSION: ${{ matrix.spark }}
         SCALA_VERSION: ${{ matrix.scala }}
+        SPARK_LOCAL_IP: "127.0.0.1"

Review comment:
       You don't need this line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org