You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/03/24 17:39:37 UTC
[PR] KAFKA-20340: Remove GroupConfigManager dependency from SharePartition [kafka]
majialoong opened a new pull request, #21861:
URL: https://github.com/apache/kafka/pull/21861
`SharePartition` held both a `GroupConfigManager` and a `ShareGroupConfigProvider` reference, but `ShareGroupConfigProvider` already wraps `GroupConfigManager`.
This PR removes the redundant `GroupConfigManager` dependency so that `SharePartition` only uses `ShareGroupConfigProvider` for dynamic group configuration lookups, as suggested in [#21627.](https://github.com/apache/kafka/pull/21627#discussion_r2944775843)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20340: Remove GroupConfigManager dependency from SharePartition [kafka]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on code in PR #21861:
URL: https://github.com/apache/kafka/pull/21861#discussion_r2989218043
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -718,7 +719,7 @@ private SharePartition getOrCreateSharePartition(SharePartitionKey sharePartitio
time,
persister,
replicaManager,
- groupConfigManager,
+ new ShareGroupConfigProvider(groupConfigManager),
Review Comment:
Thanks for the suggestion! Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20340: Remove GroupConfigManager dependency from SharePartition [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21861:
URL: https://github.com/apache/kafka/pull/21861#discussion_r2983812792
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -718,7 +719,7 @@ private SharePartition getOrCreateSharePartition(SharePartitionKey sharePartitio
time,
persister,
replicaManager,
- groupConfigManager,
+ new ShareGroupConfigProvider(groupConfigManager),
Review Comment:
`SharePartitionManager` does not use `groupConfigManager` as well, so we could pass `ShareGroupConfigProvider` to `SharePartitionManager` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20340: Remove GroupConfigManager dependency from SharePartition [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #21861:
URL: https://github.com/apache/kafka/pull/21861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org