You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "jack-moseley (via GitHub)" <gi...@apache.org> on 2023/03/15 22:57:57 UTC
[GitHub] [gobblin] jack-moseley opened a new pull request, #3662: Add matching of non-transient exceptions that will avoid failing the container in GMIP
jack-moseley opened a new pull request, #3662:
URL: https://github.com/apache/gobblin/pull/3662
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1801
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Match exceptions against a known list of non-transient/dataset-specific exceptions, and avoid counting those towards the max failed datasets in a container since they are not indicating any wider issue.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Tested in parallel GMIP pipeline by manually throwing an exception with dataset failure limit of 0
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3662: Add matching of non-transient exceptions that will avoid failing the container in GMIP
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3662:
URL: https://github.com/apache/gobblin/pull/3662#issuecomment-1470966625
## [Codecov](https://codecov.io/gh/apache/gobblin/pull/3662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3662](https://codecov.io/gh/apache/gobblin/pull/3662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b763edd) into [master](https://codecov.io/gh/apache/gobblin/commit/be6d46c2a117b1248d88d22cc64db5a12b802d16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be6d46c) will **increase** coverage by `4.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3662 +/- ##
============================================
+ Coverage 46.85% 50.94% +4.09%
+ Complexity 10749 7178 -3571
============================================
Files 2138 1345 -793
Lines 83989 50650 -33339
Branches 9331 5629 -3702
============================================
- Hits 39353 25804 -13549
+ Misses 41054 22576 -18478
+ Partials 3582 2270 -1312
```
[see 796 files with indirect coverage changes](https://codecov.io/gh/apache/gobblin/pull/3662/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] vikrambohra commented on pull request #3662: Add matching of non-transient exceptions that will avoid failing the container in GMIP
Posted by "vikrambohra (via GitHub)" <gi...@apache.org>.
vikrambohra commented on PR #3662:
URL: https://github.com/apache/gobblin/pull/3662#issuecomment-1492584637
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3662: Add matching of non-transient exceptions that will avoid failing the container in GMIP
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3662:
URL: https://github.com/apache/gobblin/pull/3662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley commented on pull request #3662: Add matching of non-transient exceptions that will avoid failing the container in GMIP
Posted by "jack-moseley (via GitHub)" <gi...@apache.org>.
jack-moseley commented on PR #3662:
URL: https://github.com/apache/gobblin/pull/3662#issuecomment-1472397578
Good point, forgot that the datasetErrorMap is also what we use to send the events. Added a new set that is used only to count the number of dataset failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org