[jira] [Commented] (FLINK-8670) Make MetricRegistryImpl#shutdown non blocking

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366825#comment-16366825 ] 

ASF GitHub Bot commented on FLINK-8670:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5504

    [FLINK-8670] Make MetricRegistryImpl#shutdown non blocking

    ## What is the purpose of the change
    
    This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead
    of waiting for the completion of the shutdown procedure, the method returns a
    future which is completed once the metric registry has completed the shut down.
    
    This PR is based on #5503.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink metricRegistryShutDown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5504
    
----
commit 51bb532d2490968635214016599475f91c5f97e5
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T09:08:04Z

    [FLINK-8669] Add completeAll and runAfterwards(Async) to FutureUtils
    
    FutureUtils#completeAll(Collection) takes a collection of futures and returns
    a future which is completed after all of the given futures are completed. This
    also includes exceptional completions. Potentially occurring exceptions are
    recorded and combined into a single exception with which the resulting future
    is completed.
    
    FutureUtils#runAfterwards takes a future and runs a given action after the
    completion of the given future. This also includes an exceptional completion.
    In this case, a potentially occurring exception as the result of the provided
    action will be combined with the future's exception.

commit 45854d259a5ff0d03fe69a9caabc5c8627be3ba9
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T07:12:04Z

    [FLINK-8670] Make MetricRegistryImpl#shutdown non blocking
    
    This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead
    of waiting for the completion of the shutdown procedure, the method returns a
    future which is completed once the metric registry has completed the shut down.

----


> Make MetricRegistryImpl#shutdown non blocking 
> ----------------------------------------------
>
>                 Key: FLINK-8670
>                 URL: https://issues.apache.org/jira/browse/FLINK-8670
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to better shut down multiple components concurrently, we should make all shutdown operation non-blocking if possible. This also includes the {{MetricRegistryImpl}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)