You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/23 07:15:56 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #18146: [CI] run pytest in parallel
szha opened a new pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146
## Description ##
run pytest in parallel
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] run small tests in parallel
- [ ] mark tests that require more resources
- [ ] run large tests in serial
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-623856601
@PatricZhao I noticed that the MKL/MKLDNN tests are taking a lot longer than non-MKL builds in the parallel test setting. I will try to run a couple more times to verify so this is just FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#discussion_r417685627
##########
File path: tests/python/train/test_resnet_aug.py
##########
@@ -39,14 +40,15 @@ def get_net():
return softmax
# check data
-get_cifar10()
+path = tempfile.mkdtemp()
Review comment:
You're not cleaning up these temporary directories. You could use pytests functionality which will handle cleanup https://docs.pytest.org/en/latest/tmpdir.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-618225038
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, clang, centos-gpu, unix-cpu, windows-cpu, unix-gpu, sanity, windows-gpu, centos-cpu, edge, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-623765421
will look into it in a follow-up PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-624251547
Update: the MKLDNN builds are actually executing a different set of tests which could explain the time difference. However, the MKL build is indeed executing the same unittest as regular python 3 CPU build and it's consistently taking a lot longer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#discussion_r417722768
##########
File path: tests/python/train/test_resnet_aug.py
##########
@@ -39,14 +40,15 @@ def get_net():
return softmax
# check data
-get_cifar10()
+path = tempfile.mkdtemp()
Review comment:
thanks. this is useful. I will replace other occurrences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-624312870
Could that be due to cold booz? Doesn't mkl generate kernels the first time
you invoke them?
Sheng Zha <no...@github.com> schrieb am Di., 5. Mai 2020, 21:13:
> Update: the MKLDNN builds are actually executing a different set of tests
> which could explain the time difference. However, the MKL build is indeed
> executing the same unittest as regular python 3 CPU build and it's
> consistently taking a lot longer.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-624251547>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEOED27YF6LHD3T3K2GP7N3RQBQNBANCNFSM4MOZZ7VQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha edited a comment on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha edited a comment on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-623856601
@PatricZhao I noticed that the MKL/MKLDNN tests are taking a lot longer than non-MKL builds in the parallel test setting. I will try to run a couple more times to verify so this is just FYI. Example:
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-18146/51/pipeline/366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18146: [CI] run pytest in parallel
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18146:
URL: https://github.com/apache/incubator-mxnet/pull/18146#issuecomment-624332388
@marcoabreu indeed that could be a likely cause. I reported my findings in #18244 and we can continue the discussion there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org