You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "edk12564 (via GitHub)" <gi...@apache.org> on 2026/02/15 03:32:49 UTC
[PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
edk12564 opened a new pull request, #5495:
URL: https://github.com/apache/fineract/pull/5495
JIRA: FINERACT-274, FINERACT-672, FINERACT-673, FINERACT-674, FINERACT-675, FINERACT-676
Pictures coming soon.
## Before
According to FINERACT-274, Fineract was creating orphaned tables whenever a datatable was rejected in the maker checker process, taking up database storage and polluting namespace.
To reproduce the problem:
1) Startup a MariaDB instance of Fineract
2) Make sure global maker-checker is on.
3) Make sure maker-checker is on for datatable creation
4) Login as a maker (not a super-user) user to frontend dev server
5) Create a new datatable
6) Login as a checker user.
7) Deny the datatable creation.
8) Examine the database and find orphaned table.
9) Reconfirm by trying to create datatable with same name, which displays an error message: data table already exists.
## Changes
The problem was found to affect the group, center, loan account, office, and savings accounts levels.
After diagnosing the issue, I found that the problem was that these were all data table creation events. It turns out that MariaDB does not add DDL (data table changes) SQL queries to a transaction, meaning when the maker-checker system rolls everything back for checking, the DDL actually executes and makes the table. This means that when the data table is rejected, the orphaned data table exists in the database. PostgreSQL includes DDL as part of the transaction boundary, meaning it is not an issue when PostgreSQL is used.
To fix the issue, I added a cleanup service after every maker-checker rejection that checks if the rejection was a data table rejection. If that was the case, it cleans up the data table in question. If not, it continues as normal. This structure allows us to keep as much original logic as possible, while working in both PostgreSQL and MariaDB use cases.
To test my changes, I also added an integration test that tests the process of data table creation, maker-checker events, and another data table creation to determine if the data table was properly removed. I do this over the group, center, loan account, office, and saving account levels to make sure they don't produce the bugs mentioned in the various tickets.
I tried to follow convention as much as possible. Feedback is welcome!
## After
Tests all pass.
Reproducing the issue no longer results in a "data table already exists" error.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5495:
URL: https://github.com/apache/fineract/pull/5495#discussion_r2826904809
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/PortfolioCommandSourceWritePlatformServiceImpl.java:
##########
@@ -49,6 +50,7 @@ public class PortfolioCommandSourceWritePlatformServiceImpl implements Portfolio
private final CommandProcessingService processAndLogCommandService;
private final SchedulerJobRunnerReadService schedulerJobRunnerReadService;
private final ConfigurationDomainService configurationService;
+ private final DatatableRejectionCleanupService ifDatatableRejectionThenCleanup;
Review Comment:
Lets rename it something more generic, like: CleanUpService and have it as an interface only. Lets inject it as a List, so multiple implementations are allowed to be used (even if there is just one for now). If the list is null, we can skip it. if not a foreach we can call all of them. The implementation classes responsibilities to decide whether there is something to be done or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on code in PR #5495:
URL: https://github.com/apache/fineract/pull/5495#discussion_r2828888408
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/PortfolioCommandSourceWritePlatformServiceImpl.java:
##########
@@ -49,6 +50,7 @@ public class PortfolioCommandSourceWritePlatformServiceImpl implements Portfolio
private final CommandProcessingService processAndLogCommandService;
private final SchedulerJobRunnerReadService schedulerJobRunnerReadService;
private final ConfigurationDomainService configurationService;
+ private final DatatableRejectionCleanupService ifDatatableRejectionThenCleanup;
Review Comment:
I'll get to work on this now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5495:
URL: https://github.com/apache/fineract/pull/5495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3923298581
> > > I dont think any of the changes are needed.
> > > The attached integration tests are green without messing with transaction boundaries, neither having the "cleanup".
> > > The maker-checker is fully rolled back, so no left over data. You can create datatable if it was rejected priorly.
> > > Kindly asking you to double check!
> >
> >
> > Firstly, thank you adam for the review!
> > I did as you said and double checked by running a few tests, both in MariaDB and Postgres. Can I ask what database you used to check the changes? I think the database matters because the issue should only affect MariaDB.
> > To clarify, the behavior of the solution and tests with a Postgres database should be a "no-op". This is because of how MariaDB handles DDL statements like creating new tables. So the problem doesn't even occur when Postgres databases are used.
> > I tried to replicate in a few circumstances and got the results below. You can also see the cleanup commented out in (without cleanup) and not commented out in (with cleanup).
> > MariaDB (without cleanup): <img alt="Screenshot 2026-02-17 at 10 06 49 PM" width="1107" height="532" src="https://private-user-images.githubusercontent.com/30848293/551328123-38f9cd95-1811-461f-9765-115611dc66b0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxMjMtMzhmOWNkOTUtMTgxMS00NjFmLTk3NjUtMTE1NjExZGM2NmIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhNzA2YzhkMzVmNDY2MWRlYzRlMTMyYzU5ZTYxZjQ2YTM4YzBjMjkyMjYxZWZlOTYwNDM1NzRkMmI3NTEwODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xWG4CCVss_uPejVSEz1SbYSEw2wgIRH0BRrnkGBxCFU">
> > MariaDB (with cleanup): <img alt="Screenshot 2026-02-17 at 10 19 26 PM" width="1093" height="547" src="https://private-user-images.githubusercontent.com/30848293/551329560-7ad506c2-b6d2-4d4e-83e4-641d7c9f2ee8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjk1NjAtN2FkNTA2YzItYjZkMi00ZDRlLTgzZTQtNjQxZDdjOWYyZWU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkNzk5MDg1YWUyMjY5MGFkYmExNzJkOWUxYWI3Yzc4MDQzOTI3ZjAxNWMyODljMTk5MTEwMDVlZGYwN2FkYTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o28_oPpKdN12Cy-BXR6iXLOj8FVLT3cYVdISDGHfmgU">
> > Postgres (without cleanup): <img alt="Screenshot 2026-02-17 at 10 07 51 PM" width="1094" height="548" src="https://private-user-images.githubusercontent.com/30848293/551328149-edbe09b3-aa1e-4fe1-a0c8-608ad0613735.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxNDktZWRiZTA5YjMtYWExZS00ZmUxLWEwYzgtNjA4YWQwNjEzNzM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1ZWIyMTMyNzBiY2U3NTA0ODkxZmIwODY1ZGEyYmZkMDE3NGY0NzE2Njk1NTEwZDc0ZjM4MzY3YTE3ZjIxNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.RyIjHRqh74o3SPmRa9csbibS_8jJl-uFaFCa1AHyqy8">
> > As for the extra @transactional I added. This was just to ensure that the removal didn't happen without the rest of the items in rejectEntry(). But thinking about it now, I don't think this is necessary, since MariaDB will commit this DDL even if it is in @transactional, just like for the table creation. I will make another change without this in there!
> > Please let me know if there's something I missed. I understand I am new and thus prone to making mistakes.
>
> OMG mariadb and mysql... OMG.... :(
😄 😄 I heard from the recent meeting, but is MariaDB and MySQL getting phased out slowly? I understand we want to be accomodative to different solutions, but I'm getting the sense this doesn't apply here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3925881533
> > > > I dont think any of the changes are needed.
> > > > The attached integration tests are green without messing with transaction boundaries, neither having the "cleanup".
> > > > The maker-checker is fully rolled back, so no left over data. You can create datatable if it was rejected priorly.
> > > > Kindly asking you to double check!
> > >
> > >
> > > Firstly, thank you adam for the review!
> > > I did as you said and double checked by running a few tests, both in MariaDB and Postgres. Can I ask what database you used to check the changes? I think the database matters because the issue should only affect MariaDB.
> > > To clarify, the behavior of the solution and tests with a Postgres database should be a "no-op". This is because of how MariaDB handles DDL statements like creating new tables. So the problem doesn't even occur when Postgres databases are used.
> > > I tried to replicate in a few circumstances and got the results below. You can also see the cleanup commented out in (without cleanup) and not commented out in (with cleanup).
> > > MariaDB (without cleanup): <img alt="Screenshot 2026-02-17 at 10 06 49 PM" width="1107" height="532" src="https://private-user-images.githubusercontent.com/30848293/551328123-38f9cd95-1811-461f-9765-115611dc66b0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxMjMtMzhmOWNkOTUtMTgxMS00NjFmLTk3NjUtMTE1NjExZGM2NmIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhNzA2YzhkMzVmNDY2MWRlYzRlMTMyYzU5ZTYxZjQ2YTM4YzBjMjkyMjYxZWZlOTYwNDM1NzRkMmI3NTEwODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xWG4CCVss_uPejVSEz1SbYSEw2wgIRH0BRrnkGBxCFU">
> > > MariaDB (with cleanup): <img alt="Screenshot 2026-02-17 at 10 19 26 PM" width="1093" height="547" src="https://private-user-images.githubusercontent.com/30848293/551329560-7ad506c2-b6d2-4d4e-83e4-641d7c9f2ee8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjk1NjAtN2FkNTA2YzItYjZkMi00ZDRlLTgzZTQtNjQxZDdjOWYyZWU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkNzk5MDg1YWUyMjY5MGFkYmExNzJkOWUxYWI3Yzc4MDQzOTI3ZjAxNWMyODljMTk5MTEwMDVlZGYwN2FkYTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o28_oPpKdN12Cy-BXR6iXLOj8FVLT3cYVdISDGHfmgU">
> > > Postgres (without cleanup): <img alt="Screenshot 2026-02-17 at 10 07 51 PM" width="1094" height="548" src="https://private-user-images.githubusercontent.com/30848293/551328149-edbe09b3-aa1e-4fe1-a0c8-608ad0613735.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxNDktZWRiZTA5YjMtYWExZS00ZmUxLWEwYzgtNjA4YWQwNjEzNzM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1ZWIyMTMyNzBiY2U3NTA0ODkxZmIwODY1ZGEyYmZkMDE3NGY0NzE2Njk1NTEwZDc0ZjM4MzY3YTE3ZjIxNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.RyIjHRqh74o3SPmRa9csbibS_8jJl-uFaFCa1AHyqy8">
> > > As for the extra @transactional I added. This was just to ensure that the removal didn't happen without the rest of the items in rejectEntry(). But thinking about it now, I don't think this is necessary, since MariaDB will commit this DDL even if it is in @transactional, just like for the table creation. I will make another change without this in there!
> > > Please let me know if there's something I missed. I understand I am new and thus prone to making mistakes.
> >
> >
> > OMG mariadb and mysql... OMG.... :(
>
> 😄 😄 I heard from the recent meeting, but is MariaDB and MySQL getting phased out slowly? I understand we want to be accomodative to different solutions, but I'm getting the sense this doesn't apply here?
Well... not as quickly as I want.. so probably this year we will still supporting 3 db engines :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on code in PR #5495:
URL: https://github.com/apache/fineract/pull/5495#discussion_r2829315274
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/PortfolioCommandSourceWritePlatformServiceImpl.java:
##########
@@ -49,6 +50,7 @@ public class PortfolioCommandSourceWritePlatformServiceImpl implements Portfolio
private final CommandProcessingService processAndLogCommandService;
private final SchedulerJobRunnerReadService schedulerJobRunnerReadService;
private final ConfigurationDomainService configurationService;
+ private final DatatableRejectionCleanupService ifDatatableRejectionThenCleanup;
Review Comment:
Just pushed my changes. Please let me know if it is good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3919569434
> > I dont think any of the changes are needed.
> > The attached integration tests are green without messing with transaction boundaries, neither having the "cleanup".
> > The maker-checker is fully rolled back, so no left over data. You can create datatable if it was rejected priorly.
> > Kindly asking you to double check!
>
> Firstly, thank you adam for the review!
>
> I did as you said and double checked by running a few tests, both in MariaDB and Postgres. Can I ask what database you used to check the changes? I think the database matters because the issue should only affect MariaDB.
>
> To clarify, the behavior of the solution and tests with a Postgres database should be a "no-op". This is because of how MariaDB handles DDL statements like creating new tables. So the problem doesn't even occur when Postgres databases are used.
>
> I tried to replicate in a few circumstances and got the results below. You can also see the cleanup commented out in (without cleanup) and not commented out in (with cleanup).
>
> MariaDB (without cleanup): <img alt="Screenshot 2026-02-17 at 10 06 49 PM" width="1107" height="532" src="https://private-user-images.githubusercontent.com/30848293/551328123-38f9cd95-1811-461f-9765-115611dc66b0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxMjMtMzhmOWNkOTUtMTgxMS00NjFmLTk3NjUtMTE1NjExZGM2NmIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhNzA2YzhkMzVmNDY2MWRlYzRlMTMyYzU5ZTYxZjQ2YTM4YzBjMjkyMjYxZWZlOTYwNDM1NzRkMmI3NTEwODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xWG4CCVss_uPejVSEz1SbYSEw2wgIRH0BRrnkGBxCFU">
>
> MariaDB (with cleanup): <img alt="Screenshot 2026-02-17 at 10 19 26 PM" width="1093" height="547" src="https://private-user-images.githubusercontent.com/30848293/551329560-7ad506c2-b6d2-4d4e-83e4-641d7c9f2ee8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjk1NjAtN2FkNTA2YzItYjZkMi00ZDRlLTgzZTQtNjQxZDdjOWYyZWU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkNzk5MDg1YWUyMjY5MGFkYmExNzJkOWUxYWI3Yzc4MDQzOTI3ZjAxNWMyODljMTk5MTEwMDVlZGYwN2FkYTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o28_oPpKdN12Cy-BXR6iXLOj8FVLT3cYVdISDGHfmgU">
>
> Postgres (without cleanup): <img alt="Screenshot 2026-02-17 at 10 07 51 PM" width="1094" height="548" src="https://private-user-images.githubusercontent.com/30848293/551328149-edbe09b3-aa1e-4fe1-a0c8-608ad0613735.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE0MDU4NDgsIm5iZiI6MTc3MTQwNTU0OCwicGF0aCI6Ii8zMDg0ODI5My81NTEzMjgxNDktZWRiZTA5YjMtYWExZS00ZmUxLWEwYzgtNjA4YWQwNjEzNzM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDA5MDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1ZWIyMTMyNzBiY2U3NTA0ODkxZmIwODY1ZGEyYmZkMDE3NGY0NzE2Njk1NTEwZDc0ZjM4MzY3YTE3ZjIxNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.RyIjHRqh74o3SPmRa9csbibS_8jJl-uFaFCa1AHyqy8">
>
> As for the extra @transactional I added. This was just to ensure that the removal didn't happen without the rest of the items in rejectEntry(). But thinking about it now, I don't think this is necessary, since MariaDB will commit this DDL even if it is in @transactional, just like for the table creation. I will make another change without this in there!
>
> Please let me know if there's something I missed. I understand I am new and thus prone to making mistakes.
OMG mariadb and mysql... OMG.... :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3936985326
> @edk12564 Please rebase this PR. Hopefully the failed checks goes away after!
Sounds good! I updated my PR and rebased. Let's just wait and see now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3933480898
@edk12564 Please rebase this PR. Hopefully the failed checks goes away after!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-274: Not able to create the same datatable which was rejected by the maker checker before [fineract]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on PR #5495:
URL: https://github.com/apache/fineract/pull/5495#issuecomment-3918523203
> I dont think any of the changes are needed.
>
> The attached integration tests are green without messing with transaction boundaries, neither having the "cleanup".
>
> The maker-checker is fully rolled back, so no left over data. You can create datatable if it was rejected priorly.
>
> Kindly asking you to double check!
Firstly, thank you adam for the review!
I did as you said and double checked by running a few tests, both in MariaDB and Postgres. Can I ask what database you used to check the changes? I think the database matters because the issue should only affect MariaDB.
To clarify, the behavior of the solution and tests with a Postgres database should be a "no-op". This is because of how MariaDB handles DDL statements like creating new tables. So the problem doesn't even occur when Postgres databases are used.
I tried to replicate in a few circumstances and got the results below.
MariaDB (without cleanup):
<img width="1107" height="532" alt="Screenshot 2026-02-17 at 10 06 49 PM" src="https://github.com/user-attachments/assets/38f9cd95-1811-461f-9765-115611dc66b0" />
MariaDB (with cleanup):
<img width="1093" height="547" alt="Screenshot 2026-02-17 at 10 19 26 PM" src="https://github.com/user-attachments/assets/7ad506c2-b6d2-4d4e-83e4-641d7c9f2ee8" />
Postgres:
<img width="1094" height="548" alt="Screenshot 2026-02-17 at 10 07 51 PM" src="https://github.com/user-attachments/assets/edbe09b3-aa1e-4fe1-a0c8-608ad0613735" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org