[GitHub] gianm commented on issue #6910: Bring GCP functionality to core functionality

[GitBox <gi...@apache.org>]

gianm commented on issue #6910: Bring GCP functionality to core functionality
URL: https://github.com/apache/incubator-druid/issues/6910#issuecomment-458681102
 
 
   @drcrallen,
   
   I am 10000% in favor of AWS and GCP being treated roughly equally, especially given your ability to commit to maintaining the GCP extension.
   
   I am less excited about adding a `gcp-common` module. I don't really love the `aws-common` module and wish it was something you only had to load if you're actually using AWS-y extensions. Your proposal would cement that, IMO, non-ideal design in place further by doing the same thing with GCP. It is unfair that I only bring this up now, but please accept my apologies for that.
   
   Would it work to remove both the `aws-common` and `gcp-common` modules from `distribution`, and switch them from `provided` to `compile` in the extensions that use them, so the extensions bundle the jars rather than it appearing in `lib/` to always be loaded? It would mean some more redundancy in extension jars (more than one extension uses AWS stuff) but it would mean that core is cleaner (no aws jars loaded if you don't need any of those extensions). It seems like a reasonable tradeoff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org