You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/19 19:58:25 UTC
[GitHub] [commons-validator] nhojpatrick opened a new pull request, #95: JUnit5 assertThrows UrlValidatorTest
nhojpatrick opened a new pull request, #95:
URL: https://github.com/apache/commons-validator/pull/95
Breaking out https://github.com/apache/commons-validator/pull/45 into separate pr's are it's hard to keep rebase these old changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] codecov-commenter commented on pull request #95: JUnit5 assertThrows UrlValidatorTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #95:
URL: https://github.com/apache/commons-validator/pull/95#issuecomment-1284538017
# [Codecov](https://codecov.io/gh/apache/commons-validator/pull/95?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#95](https://codecov.io/gh/apache/commons-validator/pull/95?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1927f43) into [master](https://codecov.io/gh/apache/commons-validator/commit/4837a668d61b5f0ba976d98aa526206d3759376a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4837a66) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #95 +/- ##
=========================================
Coverage 71.90% 71.90%
Complexity 1137 1137
=========================================
Files 63 63
Lines 3157 3157
Branches 542 542
=========================================
Hits 2270 2270
Misses 693 693
Partials 194 194
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] garydgregory commented on pull request #95: JUnit5 assertThrows UrlValidatorTest
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #95:
URL: https://github.com/apache/commons-validator/pull/95#issuecomment-1320159884
-1 This is not better, let's wait until this component is on Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] garydgregory merged pull request #95: JUnit5 assertThrows UrlValidatorTest
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #95:
URL: https://github.com/apache/commons-validator/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] nhojpatrick commented on pull request #95: JUnit5 assertThrows UrlValidatorTest
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on PR #95:
URL: https://github.com/apache/commons-validator/pull/95#issuecomment-1321313548
@garydgregory Refactor to Java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org