You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/03/07 02:42:09 UTC

[GitHub] flink pull request #5647: [FLINK-8687] Make MaterializedCollectStreamResult#...

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5647

    [FLINK-8687] Make MaterializedCollectStreamResult#retrievePage to hav…

    …e resultLock
    
    ## What is the purpose of the change
    
    Currently ```MaterializedCollectStreamResult#retrievePage``` checks page range and calls snapshot.subList() without holding resultLock. resultLock should be taken.
    
    ## Brief change log
    Add synchronized to protect it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-8687

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5647
    
----
commit e3308ba0914404d424dfbc17c70d1b948c97b175
Author: mingleiZhang <zm...@...>
Date:   2018-03-07T02:36:52Z

    [FLINK-8687] Make MaterializedCollectStreamResult#retrievePage to have resultLock

----


---

[GitHub] flink issue #5647: [FLINK-8687] Make MaterializedCollectStreamResult#retriev...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/5647
  
    Thank you @zhangminglei. Merging...


---

[GitHub] flink pull request #5647: [FLINK-8687] Make MaterializedCollectStreamResult#...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5647


---