You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by rd...@apache.org on 2010/08/09 19:47:09 UTC

svn commit: r983748 - in /hadoop/pig/trunk: CHANGES.txt src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java

Author: rding
Date: Mon Aug  9 17:47:09 2010
New Revision: 983748

URL: http://svn.apache.org/viewvc?rev=983748&view=rev
Log:
PIG-1525: Incorrect data generated by diff of SUM

Modified:
    hadoop/pig/trunk/CHANGES.txt
    hadoop/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java

Modified: hadoop/pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/pig/trunk/CHANGES.txt?rev=983748&r1=983747&r2=983748&view=diff
==============================================================================
--- hadoop/pig/trunk/CHANGES.txt (original)
+++ hadoop/pig/trunk/CHANGES.txt Mon Aug  9 17:47:09 2010
@@ -120,6 +120,8 @@ PIG-1309: Map-side Cogroup (ashutoshc)
 
 BUG FIXES
 
+PIG-1525: Incorrect data generated by diff of SUM (rding)
+
 PIG-1288: EvalFunc returnType is wrong for generic subclasses (daijy)
 
 PIG-1534: Code discovering UDFs in the script has a bug in a order by case

Modified: hadoop/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java
URL: http://svn.apache.org/viewvc/hadoop/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java?rev=983748&r1=983747&r2=983748&view=diff
==============================================================================
--- hadoop/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java (original)
+++ hadoop/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java Mon Aug  9 17:47:09 2010
@@ -458,4 +458,13 @@ public class POUserFunc extends Expressi
     public List<ExpressionOperator> getChildExpressions() {		
         return null;
     }
+    
+    @SuppressWarnings("unchecked")
+    @Override
+    public void setAccumStart() {        
+        if (isAccumulative() && !isAccumStarted()) {
+            super.setAccumStart();
+            ((Accumulator)func).cleanup();
+        }        
+    }
 }