You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "NolanMatt (via GitHub)" <gi...@apache.org> on 2023/03/29 17:06:27 UTC
[GitHub] [daffodil-vscode] NolanMatt opened a new pull request, #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
NolanMatt opened a new pull request, #540:
URL: https://github.com/apache/daffodil-vscode/pull/540
…of unnecessary delete statements in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1490384011
@NolanMatt, what is going on with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien merged pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien merged PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] NolanMatt commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "NolanMatt (via GitHub)" <gi...@apache.org>.
NolanMatt commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1488986545
Should close Issue 521, the new Global directive in build.sbt fixes
there's a key that's not used by any other settings/tasks:
[warn]
[warn] * daffodil-debugger / maintainer
[warn] +- C:\Users\nolanm\Documents\GitHub\myfork\daffodil-vscode\build.sbt:52
[warn]
Which only comes up when you remove the 3 lines at the bottom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1489461423
You will want to have a shorter commit message or take what you have and break into multiple lines. You will also need to add all issues to commit message by adding `Closes #ISSUE_NUMBER` on a separate line for each issues. Here is a sample commit from what you now:
```bash
Update build.sbt and CI.yml:
- Stop duplicating compile/test artifacts.
- Get rid of unnecessary delete statements in CI.
Closes #521
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1490902891
I really don't understand what's going on here. Since the original message was referring to schema files that existed in a path that were only meant to be a temporary location, and later moved, I removed the need to move any extracted schema files at all. However, this still failed the build--only under Node 16--with a timeout during the headless extension tests, which doesn't seem to have anything to do with TDML.
Running the same tests locally, including using Node 16, passes for me.
Rerunning the failed job makes it pass, but that doesn't reassure me. Trying another complete rerun to see if I can trigger any failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1490399254
@arosien, @NolanMatt is having a difficult time investigating the problem since it works for him locally and intermittently in CI. He indicated that you are able to reproduce issue locally, so I'll reassign it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "arosien (via GitHub)" <gi...@apache.org>.
arosien commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1490917603
@NolanMatt I can't force push to your fork, so you'll have to squash everything to get to a single commit. (or give me perms somehow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] NolanMatt commented on pull request #540: Update build.sbt to not duplicate compile/test aritfacts and get rid …
Posted by "NolanMatt (via GitHub)" <gi...@apache.org>.
NolanMatt commented on PR #540:
URL: https://github.com/apache/daffodil-vscode/pull/540#issuecomment-1489007135
Funny, it actually failed for the first time on this PR. I guess something is still up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org