You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/09 03:50:03 UTC
[GitHub] [flink] WeiZhong94 opened a new pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
WeiZhong94 opened a new pull request #12048:
URL: https://github.com/apache/flink/pull/12048
## What is the purpose of the change
*This pull request gets the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.*
## Brief change log
- *Get the real environment object from the DummyStreamExecutionEnvironment before getting the configuration.*
## Verifying this change
This change can be verified as follows:
- *Prepare a sql job with python udfs.*
- *Submit the sql job with python dependency management command line options.*
**NOTE:** This change can be verify automatically after adding the PyFlink e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #12048:
URL: https://github.com/apache/flink/pull/12048#discussion_r422455758
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/CommonPythonBase.scala
##########
@@ -136,6 +140,16 @@ trait CommonPythonBase {
config.addAll(tableConfig.getConfiguration)
config
}
+
+ private def getRealEnvironment(env: StreamExecutionEnvironment): StreamExecutionEnvironment = {
Review comment:
Should we also consider the `DummyExecutionEnvironment`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12048:
URL: https://github.com/apache/flink/pull/12048#issuecomment-626103429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=856",
"triggerID" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ea24ccc576097b489d5f0d16d464318ce3949d3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12048:
URL: https://github.com/apache/flink/pull/12048#issuecomment-626101104
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0ea24ccc576097b489d5f0d16d464318ce3949d3 (Sat May 09 03:58:05 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17586).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12048:
URL: https://github.com/apache/flink/pull/12048#issuecomment-626103429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ea24ccc576097b489d5f0d16d464318ce3949d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12048: [FLINK-17586][python] Use the real StreamExecutionEnvironment contained in DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12048:
URL: https://github.com/apache/flink/pull/12048#issuecomment-626103429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=856",
"triggerID" : "0ea24ccc576097b489d5f0d16d464318ce3949d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ea24ccc576097b489d5f0d16d464318ce3949d3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 commented on a change in pull request #12048: [FLINK-17586][python] get the real Configuration object from DummyStreamExecutionEnvironment when translating the Python UDF physical nodes to operators.
Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on a change in pull request #12048:
URL: https://github.com/apache/flink/pull/12048#discussion_r422456225
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/CommonPythonBase.scala
##########
@@ -136,6 +140,16 @@ trait CommonPythonBase {
config.addAll(tableConfig.getConfiguration)
config
}
+
+ private def getRealEnvironment(env: StreamExecutionEnvironment): StreamExecutionEnvironment = {
Review comment:
Currently it is unnecessary as the `DummyExecutionEnvironment` would not be passed to the `translateToPlan` methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org