You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/15 11:46:38 UTC
[GitHub] [druid] wangxiaobaidu11 opened a new pull request #11920: Long unique extension function for precise count distinct
wangxiaobaidu11 opened a new pull request #11920:
URL: https://github.com/apache/druid/pull/11920
Precise count distinct recalculation can be performed for numeric types
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] wangxiaobaidu11 commented on pull request #11920: Long unique extension function for precise count distinct
Posted by GitBox <gi...@apache.org>.
wangxiaobaidu11 commented on pull request #11920:
URL: https://github.com/apache/druid/pull/11920#issuecomment-982272744
> Hi, @wangxiaobaidu11 . There was a failure in Travis, which was caused by the lack of a declaration of this new module in the root pom file, as follows:
>
> ```
> <module>extensions-contrib/long-unique</module>
> ```
>
> Please add it to pass the CI system before further code review. FYI, https://github.com/apache/druid/blob/master/pom.xml#L200
thank you！ I changed it recently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] wangxiaobaidu11 commented on pull request #11920: Long unique extension function for precise count distinct
Posted by GitBox <gi...@apache.org>.
wangxiaobaidu11 commented on pull request #11920:
URL: https://github.com/apache/druid/pull/11920#issuecomment-982273694
> @wangxiaobaidu11 Thanks for your contribution. I think it's a useful aggregator to count distinct on Long dimensions. Could you add a benchmark test to see the performance of this new aggregator?
thank you！I will add bench Mark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #11920: Long unique extension function for precise count distinct
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on pull request #11920:
URL: https://github.com/apache/druid/pull/11920#issuecomment-976364450
@wangxiaobaidu11 Thanks for your contribution. I think it's a useful aggregator to count distinct on Long dimensions. Could you add a benchmark test to see the performance of this new aggregator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org