[GitHub] [iceberg] openinx commented on a change in pull request #1219: Make GenericManifestFile using Iceberg generic data model

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #1219:
URL: https://github.com/apache/iceberg/pull/1219#discussion_r502763700



##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -68,12 +74,14 @@ public GenericManifestFile(org.apache.avro.Schema avroSchema) {
     List<Types.NestedField> allFields = ManifestFile.schema().asStruct().fields();
 
     this.fromProjectionPos = new int[fields.size()];
+    this.nameToProjectedPos = new HashMap<>();

Review comment:
       nit:  we usually use `Maps.newHashMap`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org