[GitHub] [ozone] adoroszlai commented on a change in pull request #2599: HDDS-5701. Add auditLog when DN register fail

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2599:
URL: https://github.com/apache/ozone/pull/2599#discussion_r793922628



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -241,6 +241,9 @@ public SCMRegisteredResponseProto register(
                       pipelineReportsProto));
     }
     try {
+      Preconditions.checkState(registeredCommand.getError()
+              == SCMRegisteredResponseProto.ErrorCode.success,
+          "DataNode has higher Software Layout Version than SCM.");

Review comment:
       @wzhallright Would you mind adding a slightly different check, which does not log an exception unnecessarily?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org