You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/10 12:19:12 UTC
[GitHub] [airflow] potiuk opened a new pull request #18871: Strips post-fixes from docker version
potiuk opened a new pull request #18871:
URL: https://github.com/apache/airflow/pull/18871
This version will strip any + alpha postfixes from docker version.
Seems that CodeQL uses azure-specific docker version and the
version is postfixed with `+azure`. This change will strip postfix
but also will not fail docker version check in case of similar
error, it will continue running with a warning if version cannot
be retrieved.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #18871: Strips post-fixes from docker version
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #18871:
URL: https://github.com/apache/airflow/pull/18871#discussion_r725634763
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -907,7 +907,14 @@ function initialization::ver() {
function initialization::check_docker_version() {
local docker_version
- docker_version=$(docker version --format '{{.Client.Version}}')
+ # In GitHub Code QL, the version of docker has +azure postfix which we should remove
Review comment:
```suggestion
# In GitHub Code QL, the version of docker has +azure suffix which we should remove
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18871: Strips post-fixes from docker version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18871:
URL: https://github.com/apache/airflow/pull/18871#issuecomment-939472667
Example failure here: https://github.com/apache/airflow/runs/3851284100?check_suite_focus=true#step:3:13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18871: Strips post-fixes from docker version
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18871:
URL: https://github.com/apache/airflow/pull/18871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org