You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Jaroslav Tulach <ja...@gmail.com> on 2017/10/23 08:29:32 UTC
[RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
The vote started four days ago, so it is time to announce the result:
Approved.
Bertrand Delacretaz: +1
John D. Ament: Here's my +1 to release.
Mark Struberg: +1 IPMC binding ...
Ate Douma: +1 (binding)
No vote against, four binding approvals, plus one extra:
Wade Chandler: +1
Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
-jt
2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <ja...@gmail.com>:
> 2017-10-21 14:06 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:
>
>> +1 IPMC binding
>>
>> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
>>
>> However when building it from the distribution zip on my macbook with
>> java8 144 I sometimes get test errors.
>> All of them in knockout.js, but each time something different:
>>
>
> Thanks for the review and testing. I've recorded the problem as
> https://issues.apache.org/jira/browse/NETBEANS-99
>
>
>> Running the build for the forth time made it succeed.
>> I'd say it's not a blocker for the release, but we might improve the test
>> setup.
>>
>
> The JavaFX WebView component is a moving target - every update of JDK8
> behaves differently. Let's release and seek the fix in subsequent release.
>
> > txs for rolling the release!
>
> Release early, release often!
> -jt
>
>
> > Am 21.10.2017 um 14:04 schrieb John D. Ament <jo...@apache.org>:
>> >
>> > Here's my +1 to release.
>> >
>> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
>> > bdelacretaz@codeconsult.ch> wrote:
>> >
>> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
>> >> <ja...@gmail.com> wrote:
>> >>> ...I'd like to ask you to hold the Incubator
>> >>> PMC vote to release:..
>> >>
>> >> Here's my +1 repeated from the podling list for
>> >>
>> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
>> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
>> >>
>> >> Jaroslav's GPG key is included in
>> >> https://people.apache.org/keys/group/netbeans.asc
>> >>
>> >> -Bertrand
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> >> For additional commands, e-mail: general-help@incubator.apache.org
>> >>
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Dave Schoorl <ds...@bkwi.nl>.
Ah, I see, you are right. For most artifacts, a more complex filename is used, like “net.java.html.boot”. xhr4j and ko4j being the exceptions. Should we use the maven coordinates (groupId.artifactId) for these as Automatic-Module-Name attribute in their manifest files?
Dave
> Op 9 november 2017 om 10:21 schreef Anton Epple <to...@eppleton.de>:
>
>
> As I said, the JAR-Names are sensible and will lead to a proper unique automatic module name which is unique on module path, e.g. “net.java.html.boot” . Still I think it’s good to add the manifest entry, as it indicates we care about modules.
>
> I would oppose to using org.apache.netbeans.html yet. The module name should be the same as OSGi Bundle-SymbolicName and maven coordinates (groupId.artifactId). Otherwise it would be confusing. If we decide to change this then all of them should change.
>
> --Toni
>
>
>
>
> Am 09.11.17, 09:00 schrieb "Dave Schoorl" <ds...@bkwi.nl>:
>
> That is correct. But please note, that a module name must be unique on the module path. In order to prevent name collisions, you should provide a propper name, probably containing a reverse DNS name like in packages. And if it is something in maven central, I believe there are more restrictions, E.g. regarding the groupId. I saw a presentation of Robert Scholte (maven committer) at Devoxx yesterday explaining this stuff.
>
> To keep your module name unique, I propose to start it of with org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there other suggestions?
>
> I will try to make a pull request this weekend at the latest.
>
> Kind regards,
> Dave
>
>
> > Op 9 november 2017 om 7:53 schreef Anton Epple <to...@eppleton.de>:
> >
> >
> > @Geertjan: All JARs are treated as automatic modules in Java 9, regardless of this entry in manifest. Only difference of manifest entry is that you can provide a proper name others can rely on.
> >
> > In absence of the manifest entry, the JPMS derives an automatic module name from the name of the jar stripping version numbers. Since the jar names are sensible in case of HTML-Java APIs (reverse domain), the module name will probably be correct. The automatic module name we put in manifest will make no difference as it’s the same string as the automatically derived one.
> >
> > That said, since all that is needed is to put a key in manifest, we should do that. This way it’s guaranteed to work, and we don’t need to test if automatic name is really correct :-).
> >
> > --Toni
> >
> >
> >
> > Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <ge...@googlemail.com>:
> >
> > But Dave's idea of including Automatic-Module-Name would make HTML/Java API
> > an automatic JDK 9 module (
> > http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
> >
> > Maybe a cool idea, what would the problem be, and maybe Dave should provide
> > a pull request for this?
> >
> > Gj
> >
> > On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
> > wrote:
> >
> > > Hello Dave,
> > > I know little about desirable changes to target JDK9. However if you want
> > > to start development that would bring HTML/Java API closer to JDK9, you are
> > > more than welcomed. Of course, that would be for some future release, not
> > > 1.5.x.
> > > -jt
> > >
> > >
> > > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
> > >
> > > > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > > > now that Java9 is out? Especially since these files end up in public
> > > maven
> > > > repo.
> > > >
> > > > Kind regards,
> > > >
> > > > Dave
> > > >
> > > >
> > > > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > > > jaroslav.tulach@gmail.com>:
> > > >
> > > > OK, the bits are now in
> > > > https://dist.apache.org/repos/dist/release/incubator/
> > > > netbeans/incubating-netbeans-html4j/
> > > > directory since revision 23014.
> > > >
> > > > Since revision 23015 the files are removed from the
> > > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > > directory.
> > > >
> > > > The release 1.5 is out! Time to prepare 1.5.1...
> > > > -jt
> > > >
> > > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> > > >
> > > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > > >
> > > > <ja...@gmail.com> wrote:
> > > >
> > > > ...Does it still make sense to do official release of
> > > > version 1.5 or can we skip that?...
> > > >
> > > > IIUC the only thing left is to move that release under
> > > > /dist/release/incubator/netbeans - I think you should do it to
> > > > demonstrate the complete process.
> > > >
> > > > If you don't expect people to use that release it's fine to avoid
> > > > "advertising" it.
> > > >
> > > > -Bertrand
> > > >
> > >
> >
> >
> >
>
>
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Anton Epple <to...@eppleton.de>.
As I said, the JAR-Names are sensible and will lead to a proper unique automatic module name which is unique on module path, e.g. “net.java.html.boot” . Still I think it’s good to add the manifest entry, as it indicates we care about modules.
I would oppose to using org.apache.netbeans.html yet. The module name should be the same as OSGi Bundle-SymbolicName and maven coordinates (groupId.artifactId). Otherwise it would be confusing. If we decide to change this then all of them should change.
--Toni
Am 09.11.17, 09:00 schrieb "Dave Schoorl" <ds...@bkwi.nl>:
That is correct. But please note, that a module name must be unique on the module path. In order to prevent name collisions, you should provide a propper name, probably containing a reverse DNS name like in packages. And if it is something in maven central, I believe there are more restrictions, E.g. regarding the groupId. I saw a presentation of Robert Scholte (maven committer) at Devoxx yesterday explaining this stuff.
To keep your module name unique, I propose to start it of with org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there other suggestions?
I will try to make a pull request this weekend at the latest.
Kind regards,
Dave
> Op 9 november 2017 om 7:53 schreef Anton Epple <to...@eppleton.de>:
>
>
> @Geertjan: All JARs are treated as automatic modules in Java 9, regardless of this entry in manifest. Only difference of manifest entry is that you can provide a proper name others can rely on.
>
> In absence of the manifest entry, the JPMS derives an automatic module name from the name of the jar stripping version numbers. Since the jar names are sensible in case of HTML-Java APIs (reverse domain), the module name will probably be correct. The automatic module name we put in manifest will make no difference as it’s the same string as the automatically derived one.
>
> That said, since all that is needed is to put a key in manifest, we should do that. This way it’s guaranteed to work, and we don’t need to test if automatic name is really correct :-).
>
> --Toni
>
>
>
> Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <ge...@googlemail.com>:
>
> But Dave's idea of including Automatic-Module-Name would make HTML/Java API
> an automatic JDK 9 module (
> http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
>
> Maybe a cool idea, what would the problem be, and maybe Dave should provide
> a pull request for this?
>
> Gj
>
> On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
> wrote:
>
> > Hello Dave,
> > I know little about desirable changes to target JDK9. However if you want
> > to start development that would bring HTML/Java API closer to JDK9, you are
> > more than welcomed. Of course, that would be for some future release, not
> > 1.5.x.
> > -jt
> >
> >
> > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
> >
> > > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > > now that Java9 is out? Especially since these files end up in public
> > maven
> > > repo.
> > >
> > > Kind regards,
> > >
> > > Dave
> > >
> > >
> > > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > > jaroslav.tulach@gmail.com>:
> > >
> > > OK, the bits are now in
> > > https://dist.apache.org/repos/dist/release/incubator/
> > > netbeans/incubating-netbeans-html4j/
> > > directory since revision 23014.
> > >
> > > Since revision 23015 the files are removed from the
> > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > directory.
> > >
> > > The release 1.5 is out! Time to prepare 1.5.1...
> > > -jt
> > >
> > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> > >
> > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > >
> > > <ja...@gmail.com> wrote:
> > >
> > > ...Does it still make sense to do official release of
> > > version 1.5 or can we skip that?...
> > >
> > > IIUC the only thing left is to move that release under
> > > /dist/release/incubator/netbeans - I think you should do it to
> > > demonstrate the complete process.
> > >
> > > If you don't expect people to use that release it's fine to avoid
> > > "advertising" it.
> > >
> > > -Bertrand
> > >
> >
>
>
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Dave Schoorl <ds...@bkwi.nl>.
Now, it is not my itch. I don't use the artifacts as dependency in my applications yet. It may be or become other peoples pain, now or on the future. Nevertheless, I will try to make a pull request, however, the next couple of days I have very limited time. I will try to do it over the next couple of days.
Dave
>
> Op 9 november 2017 om 9:32 schreef Geertjan Wielenga <ge...@googlemail.com>:
>
> Hi Dave,
>
> This is your itch, feel free to scratch it, i.e., pull request. :-)
>
> Gj
>
> On Thu, 9 Nov 2017 at 09:30, Dave Schoorl <ds...@bkwi.nl> wrote:
>
> > >
> > This is the link to the presentation of Robert Scholte at Devoxx (half
> > hour): https://www.youtube.com/watch?v=tHTmFlVAyAc
> >
> > >
> >
> > > > >
> > > Op 9 november 2017 om 9:00 schreef Dave Schoorl <ds...@bkwi.nl>:
> > >
> > > That is correct. But please note, that a module name must be unique
> > > on the module path. In order to prevent name collisions, you should provide
> > > a propper name, probably containing a reverse DNS name like in packages.
> > > And if it is something in maven central, I believe there are more
> > > restrictions, E.g. regarding the groupId. I saw a presentation of Robert
> > > Scholte (maven committer) at Devoxx yesterday explaining this stuff.
> > >
> > > To keep your module name unique, I propose to start it of with
> > > org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there
> > > other suggestions?
> > >
> > > I will try to make a pull request this weekend at the latest.
> > >
> > > Kind regards,
> > > Dave
> > >
> > > > > > >
> > > > >
> > > > Op 9 november 2017 om 7:53 schreef Anton Epple <
> > > > toni.epple@eppleton.de>:
> > > >
> > > > @Geertjan: All JARs are treated as automatic modules in Java
> > > > 9, regardless of this entry in manifest. Only difference of manifest entry
> > > > is that you can provide a proper name others can rely on.
> > > >
> > > > In absence of the manifest entry, the JPMS derives an
> > > > automatic module name from the name of the jar stripping version numbers.
> > > > Since the jar names are sensible in case of HTML-Java APIs (reverse
> > > > domain), the module name will probably be correct. The automatic module
> > > > name we put in manifest will make no difference as it’s the same string as
> > > > the automatically derived one.
> > > >
> > > > That said, since all that is needed is to put a key in
> > > > manifest, we should do that. This way it’s guaranteed to work, and we don’t
> > > > need to test if automatic name is really correct :-).
> > > >
> > > > --Toni
> > > >
> > > > Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <
> > > > geertjan.wielenga@googlemail.com>:
> > > >
> > > > But Dave's idea of including Automatic-Module-Name would make
> > > > HTML/Java API
> > > > an automatic JDK 9 module (
> > > >
> > > > http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
> > > >
> > > > Maybe a cool idea, what would the problem be, and maybe Dave
> > > > should provide
> > > > a pull request for this?
> > > >
> > > > Gj
> > > >
> > > > On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <
> > > > jaroslav.tulach@gmail.com>
> > > > wrote:
> > > >
> > > > > > > > >
> > > > > > > > > > >
> > > > > > >
> > > > > > Hello Dave,
> > > > > > I know little about desirable changes to target JDK9.
> > > > > > However if you want
> > > > > > to start development that would bring HTML/Java API
> > > > > > closer to JDK9, you are
> > > > > > more than welcomed. Of course, that would be for some
> > > > > > future release, not
> > > > > > 1.5.x.
> > > > > > -jt
> > > > > >
> > > > > > > > > > >
> > > > > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <dschoorl@bkwi.nl
> > > > > :
> > > > >
> > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > >
> > > > > > > > Should we not add Automatic-Module-Name attribute
> > > > > > > > to the jar's manifests,
> > > > > > > > now that Java9 is out? Especially since these
> > > > > > > > files end up in public
> > > > > > > > maven
> > > > > > > > repo.
> > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > Kind regards,
> > > > > >
> > > > > > Dave
> > > > > >
> > > > > > Op 8 november 2017 om 20:40 schreef Jaroslav
> > > > > > Tulach <
> > > > > > jaroslav.tulach@gmail.com>:
> > > > > >
> > > > > > OK, the bits are now in
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/release/incubator/
> > > > > > netbeans/incubating-netbeans-html4j/
> > > > > > directory since revision 23014.
> > > > > >
> > > > > > Since revision 23015 the files are removed from the
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > > > > directory.
> > > > > >
> > > > > > The release 1.5 is out! Time to prepare 1.5.1...
> > > > > > -jt
> > > > > >
> > > > > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <
> > > > > > bdelacretaz@apache.org>:
> > > > > >
> > > > > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > > > > >
> > > > > > <ja...@gmail.com> wrote:
> > > > > >
> > > > > > ...Does it still make sense to do official release
> > > > > > of
> > > > > > version 1.5 or can we skip that?...
> > > > > >
> > > > > > IIUC the only thing left is to move that release
> > > > > > under
> > > > > > /dist/release/incubator/netbeans - I think you
> > > > > > should do it to
> > > > > > demonstrate the complete process.
> > > > > >
> > > > > > If you don't expect people to use that release
> > > > > > it's fine to avoid
> > > > > > "advertising" it.
> > > > > >
> > > > > > -Bertrand
> > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Hi Dave,
This is your itch, feel free to scratch it, i.e., pull request. :-)
Gj
On Thu, 9 Nov 2017 at 09:30, Dave Schoorl <ds...@bkwi.nl> wrote:
> This is the link to the presentation of Robert Scholte at Devoxx (half
> hour): https://www.youtube.com/watch?v=tHTmFlVAyAc
>
> >
> > Op 9 november 2017 om 9:00 schreef Dave Schoorl <ds...@bkwi.nl>:
> >
> > That is correct. But please note, that a module name must be unique
> on the module path. In order to prevent name collisions, you should provide
> a propper name, probably containing a reverse DNS name like in packages.
> And if it is something in maven central, I believe there are more
> restrictions, E.g. regarding the groupId. I saw a presentation of Robert
> Scholte (maven committer) at Devoxx yesterday explaining this stuff.
> >
> > To keep your module name unique, I propose to start it of with
> org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there
> other suggestions?
> >
> > I will try to make a pull request this weekend at the latest.
> >
> > Kind regards,
> > Dave
> >
> > > >
> > > Op 9 november 2017 om 7:53 schreef Anton Epple <
> toni.epple@eppleton.de>:
> > >
> > > @Geertjan: All JARs are treated as automatic modules in Java
> 9, regardless of this entry in manifest. Only difference of manifest entry
> is that you can provide a proper name others can rely on.
> > >
> > > In absence of the manifest entry, the JPMS derives an
> automatic module name from the name of the jar stripping version numbers.
> Since the jar names are sensible in case of HTML-Java APIs (reverse
> domain), the module name will probably be correct. The automatic module
> name we put in manifest will make no difference as it’s the same string as
> the automatically derived one.
> > >
> > > That said, since all that is needed is to put a key in
> manifest, we should do that. This way it’s guaranteed to work, and we don’t
> need to test if automatic name is really correct :-).
> > >
> > > --Toni
> > >
> > > Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <
> geertjan.wielenga@googlemail.com>:
> > >
> > > But Dave's idea of including Automatic-Module-Name would make
> HTML/Java API
> > > an automatic JDK 9 module (
> > >
> http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
> > >
> > > Maybe a cool idea, what would the problem be, and maybe Dave
> should provide
> > > a pull request for this?
> > >
> > > Gj
> > >
> > > On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <
> jaroslav.tulach@gmail.com>
> > > wrote:
> > >
> > > > > >
> > > > Hello Dave,
> > > > I know little about desirable changes to target JDK9.
> However if you want
> > > > to start development that would bring HTML/Java API
> closer to JDK9, you are
> > > > more than welcomed. Of course, that would be for some
> future release, not
> > > > 1.5.x.
> > > > -jt
> > > >
> > > > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <dschoorl@bkwi.nl
> >:
> > > >
> > > > > > > >
> > > > > Should we not add Automatic-Module-Name attribute
> to the jar's manifests,
> > > > > now that Java9 is out? Especially since these
> files end up in public
> > > > > maven
> > > > > repo.
> > > > >
> > > > > Kind regards,
> > > > >
> > > > > Dave
> > > > >
> > > > > Op 8 november 2017 om 20:40 schreef Jaroslav
> Tulach <
> > > > > jaroslav.tulach@gmail.com>:
> > > > >
> > > > > OK, the bits are now in
> > > > >
> https://dist.apache.org/repos/dist/release/incubator/
> > > > > netbeans/incubating-netbeans-html4j/
> > > > > directory since revision 23014.
> > > > >
> > > > > Since revision 23015 the files are removed from the
> > > > >
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > > > directory.
> > > > >
> > > > > The release 1.5 is out! Time to prepare 1.5.1...
> > > > > -jt
> > > > >
> > > > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <
> bdelacretaz@apache.org>:
> > > > >
> > > > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > > > >
> > > > > <ja...@gmail.com> wrote:
> > > > >
> > > > > ...Does it still make sense to do official release
> of
> > > > > version 1.5 or can we skip that?...
> > > > >
> > > > > IIUC the only thing left is to move that release
> under
> > > > > /dist/release/incubator/netbeans - I think you
> should do it to
> > > > > demonstrate the complete process.
> > > > >
> > > > > If you don't expect people to use that release
> it's fine to avoid
> > > > > "advertising" it.
> > > > >
> > > > > -Bertrand
> > > > >
> > > > > > > >
> > > > > >
> > > >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Dave Schoorl <ds...@bkwi.nl>.
This is the link to the presentation of Robert Scholte at Devoxx (half hour): https://www.youtube.com/watch?v=tHTmFlVAyAc
>
> Op 9 november 2017 om 9:00 schreef Dave Schoorl <ds...@bkwi.nl>:
>
> That is correct. But please note, that a module name must be unique on the module path. In order to prevent name collisions, you should provide a propper name, probably containing a reverse DNS name like in packages. And if it is something in maven central, I believe there are more restrictions, E.g. regarding the groupId. I saw a presentation of Robert Scholte (maven committer) at Devoxx yesterday explaining this stuff.
>
> To keep your module name unique, I propose to start it of with org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there other suggestions?
>
> I will try to make a pull request this weekend at the latest.
>
> Kind regards,
> Dave
>
> > >
> > Op 9 november 2017 om 7:53 schreef Anton Epple <to...@eppleton.de>:
> >
> > @Geertjan: All JARs are treated as automatic modules in Java 9, regardless of this entry in manifest. Only difference of manifest entry is that you can provide a proper name others can rely on.
> >
> > In absence of the manifest entry, the JPMS derives an automatic module name from the name of the jar stripping version numbers. Since the jar names are sensible in case of HTML-Java APIs (reverse domain), the module name will probably be correct. The automatic module name we put in manifest will make no difference as it’s the same string as the automatically derived one.
> >
> > That said, since all that is needed is to put a key in manifest, we should do that. This way it’s guaranteed to work, and we don’t need to test if automatic name is really correct :-).
> >
> > --Toni
> >
> > Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <ge...@googlemail.com>:
> >
> > But Dave's idea of including Automatic-Module-Name would make HTML/Java API
> > an automatic JDK 9 module (
> > http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
> >
> > Maybe a cool idea, what would the problem be, and maybe Dave should provide
> > a pull request for this?
> >
> > Gj
> >
> > On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
> > wrote:
> >
> > > > >
> > > Hello Dave,
> > > I know little about desirable changes to target JDK9. However if you want
> > > to start development that would bring HTML/Java API closer to JDK9, you are
> > > more than welcomed. Of course, that would be for some future release, not
> > > 1.5.x.
> > > -jt
> > >
> > > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
> > >
> > > > > > >
> > > > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > > > now that Java9 is out? Especially since these files end up in public
> > > > maven
> > > > repo.
> > > >
> > > > Kind regards,
> > > >
> > > > Dave
> > > >
> > > > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > > > jaroslav.tulach@gmail.com>:
> > > >
> > > > OK, the bits are now in
> > > > https://dist.apache.org/repos/dist/release/incubator/
> > > > netbeans/incubating-netbeans-html4j/
> > > > directory since revision 23014.
> > > >
> > > > Since revision 23015 the files are removed from the
> > > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > > directory.
> > > >
> > > > The release 1.5 is out! Time to prepare 1.5.1...
> > > > -jt
> > > >
> > > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> > > >
> > > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > > >
> > > > <ja...@gmail.com> wrote:
> > > >
> > > > ...Does it still make sense to do official release of
> > > > version 1.5 or can we skip that?...
> > > >
> > > > IIUC the only thing left is to move that release under
> > > > /dist/release/incubator/netbeans - I think you should do it to
> > > > demonstrate the complete process.
> > > >
> > > > If you don't expect people to use that release it's fine to avoid
> > > > "advertising" it.
> > > >
> > > > -Bertrand
> > > >
> > > > > > >
> > > > >
> > >
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
All HTML/Java modules are OSGi bundles. The automatic module name shall be
the same as Bundle-SymbolicName, I assume. The manifest entry is defined
here:
https://github.com/apache/incubator-netbeans-html4j/blob/master/pom.xml#L329
Feel free to create the PR.
I wanted to prepare 1.5.1 release relatively soon - e.g. on Friday. In
addition to manifest changes I'd be interested in having a test case that
verifies the behavior - just like there are tests for [Felix](
https://github.com/apache/incubator-netbeans-html4j/tree/master/ko-felix-test)
and [Equinox](
https://github.com/apache/incubator-netbeans-html4j/tree/master/ko-osgi-test).
How long developing everything with such test will take? I don't want to
needlessly delay bugfixes coming with 1.5.1 for a new nice to have feature.
-jt
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Dave Schoorl <ds...@bkwi.nl>.
That is correct. But please note, that a module name must be unique on the module path. In order to prevent name collisions, you should provide a propper name, probably containing a reverse DNS name like in packages. And if it is something in maven central, I believe there are more restrictions, E.g. regarding the groupId. I saw a presentation of Robert Scholte (maven committer) at Devoxx yesterday explaining this stuff.
To keep your module name unique, I propose to start it of with org.apache.netbeans.html, like org.apache.netbeans.html.xhr4j. Or are there other suggestions?
I will try to make a pull request this weekend at the latest.
Kind regards,
Dave
> Op 9 november 2017 om 7:53 schreef Anton Epple <to...@eppleton.de>:
>
>
> @Geertjan: All JARs are treated as automatic modules in Java 9, regardless of this entry in manifest. Only difference of manifest entry is that you can provide a proper name others can rely on.
>
> In absence of the manifest entry, the JPMS derives an automatic module name from the name of the jar stripping version numbers. Since the jar names are sensible in case of HTML-Java APIs (reverse domain), the module name will probably be correct. The automatic module name we put in manifest will make no difference as it’s the same string as the automatically derived one.
>
> That said, since all that is needed is to put a key in manifest, we should do that. This way it’s guaranteed to work, and we don’t need to test if automatic name is really correct :-).
>
> --Toni
>
>
>
> Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <ge...@googlemail.com>:
>
> But Dave's idea of including Automatic-Module-Name would make HTML/Java API
> an automatic JDK 9 module (
> http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
>
> Maybe a cool idea, what would the problem be, and maybe Dave should provide
> a pull request for this?
>
> Gj
>
> On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
> wrote:
>
> > Hello Dave,
> > I know little about desirable changes to target JDK9. However if you want
> > to start development that would bring HTML/Java API closer to JDK9, you are
> > more than welcomed. Of course, that would be for some future release, not
> > 1.5.x.
> > -jt
> >
> >
> > 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
> >
> > > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > > now that Java9 is out? Especially since these files end up in public
> > maven
> > > repo.
> > >
> > > Kind regards,
> > >
> > > Dave
> > >
> > >
> > > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > > jaroslav.tulach@gmail.com>:
> > >
> > > OK, the bits are now in
> > > https://dist.apache.org/repos/dist/release/incubator/
> > > netbeans/incubating-netbeans-html4j/
> > > directory since revision 23014.
> > >
> > > Since revision 23015 the files are removed from the
> > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > > directory.
> > >
> > > The release 1.5 is out! Time to prepare 1.5.1...
> > > -jt
> > >
> > > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> > >
> > > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> > >
> > > <ja...@gmail.com> wrote:
> > >
> > > ...Does it still make sense to do official release of
> > > version 1.5 or can we skip that?...
> > >
> > > IIUC the only thing left is to move that release under
> > > /dist/release/incubator/netbeans - I think you should do it to
> > > demonstrate the complete process.
> > >
> > > If you don't expect people to use that release it's fine to avoid
> > > "advertising" it.
> > >
> > > -Bertrand
> > >
> >
>
>
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Anton Epple <to...@eppleton.de>.
@Geertjan: All JARs are treated as automatic modules in Java 9, regardless of this entry in manifest. Only difference of manifest entry is that you can provide a proper name others can rely on.
In absence of the manifest entry, the JPMS derives an automatic module name from the name of the jar stripping version numbers. Since the jar names are sensible in case of HTML-Java APIs (reverse domain), the module name will probably be correct. The automatic module name we put in manifest will make no difference as it’s the same string as the automatically derived one.
That said, since all that is needed is to put a key in manifest, we should do that. This way it’s guaranteed to work, and we don’t need to test if automatic name is really correct :-).
--Toni
Am 09.11.17, 06:41 schrieb "Geertjan Wielenga" <ge...@googlemail.com>:
But Dave's idea of including Automatic-Module-Name would make HTML/Java API
an automatic JDK 9 module (
http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
Maybe a cool idea, what would the problem be, and maybe Dave should provide
a pull request for this?
Gj
On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
wrote:
> Hello Dave,
> I know little about desirable changes to target JDK9. However if you want
> to start development that would bring HTML/Java API closer to JDK9, you are
> more than welcomed. Of course, that would be for some future release, not
> 1.5.x.
> -jt
>
>
> 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
>
> > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > now that Java9 is out? Especially since these files end up in public
> maven
> > repo.
> >
> > Kind regards,
> >
> > Dave
> >
> >
> > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > jaroslav.tulach@gmail.com>:
> >
> > OK, the bits are now in
> > https://dist.apache.org/repos/dist/release/incubator/
> > netbeans/incubating-netbeans-html4j/
> > directory since revision 23014.
> >
> > Since revision 23015 the files are removed from the
> > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > directory.
> >
> > The release 1.5 is out! Time to prepare 1.5.1...
> > -jt
> >
> > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> >
> > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> >
> > <ja...@gmail.com> wrote:
> >
> > ...Does it still make sense to do official release of
> > version 1.5 or can we skip that?...
> >
> > IIUC the only thing left is to move that release under
> > /dist/release/incubator/netbeans - I think you should do it to
> > demonstrate the complete process.
> >
> > If you don't expect people to use that release it's fine to avoid
> > "advertising" it.
> >
> > -Bertrand
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Geertjan Wielenga <ge...@googlemail.com>.
But Dave's idea of including Automatic-Module-Name would make HTML/Java API
an automatic JDK 9 module (
http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html).
Maybe a cool idea, what would the problem be, and maybe Dave should provide
a pull request for this?
Gj
On Thu, Nov 9, 2017 at 6:39 AM, Jaroslav Tulach <ja...@gmail.com>
wrote:
> Hello Dave,
> I know little about desirable changes to target JDK9. However if you want
> to start development that would bring HTML/Java API closer to JDK9, you are
> more than welcomed. Of course, that would be for some future release, not
> 1.5.x.
> -jt
>
>
> 2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
>
> > Should we not add Automatic-Module-Name attribute to the jar's manifests,
> > now that Java9 is out? Especially since these files end up in public
> maven
> > repo.
> >
> > Kind regards,
> >
> > Dave
> >
> >
> > Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> > jaroslav.tulach@gmail.com>:
> >
> > OK, the bits are now in
> > https://dist.apache.org/repos/dist/release/incubator/
> > netbeans/incubating-netbeans-html4j/
> > directory since revision 23014.
> >
> > Since revision 23015 the files are removed from the
> > https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> > directory.
> >
> > The release 1.5 is out! Time to prepare 1.5.1...
> > -jt
> >
> > 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> >
> > On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> >
> > <ja...@gmail.com> wrote:
> >
> > ...Does it still make sense to do official release of
> > version 1.5 or can we skip that?...
> >
> > IIUC the only thing left is to move that release under
> > /dist/release/incubator/netbeans - I think you should do it to
> > demonstrate the complete process.
> >
> > If you don't expect people to use that release it's fine to avoid
> > "advertising" it.
> >
> > -Bertrand
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
Hello Dave,
I know little about desirable changes to target JDK9. However if you want
to start development that would bring HTML/Java API closer to JDK9, you are
more than welcomed. Of course, that would be for some future release, not
1.5.x.
-jt
2017-11-09 0:52 GMT+01:00 Dave Schoorl <ds...@bkwi.nl>:
> Should we not add Automatic-Module-Name attribute to the jar's manifests,
> now that Java9 is out? Especially since these files end up in public maven
> repo.
>
> Kind regards,
>
> Dave
>
>
> Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <
> jaroslav.tulach@gmail.com>:
>
> OK, the bits are now in
> https://dist.apache.org/repos/dist/release/incubator/
> netbeans/incubating-netbeans-html4j/
> directory since revision 23014.
>
> Since revision 23015 the files are removed from the
> https://dist.apache.org/repos/dist/dev/incubator/netbeans/
> directory.
>
> The release 1.5 is out! Time to prepare 1.5.1...
> -jt
>
> 2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
>
> On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
>
> <ja...@gmail.com> wrote:
>
> ...Does it still make sense to do official release of
> version 1.5 or can we skip that?...
>
> IIUC the only thing left is to move that release under
> /dist/release/incubator/netbeans - I think you should do it to
> demonstrate the complete process.
>
> If you don't expect people to use that release it's fine to avoid
> "advertising" it.
>
> -Bertrand
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Dave Schoorl <ds...@bkwi.nl>.
Should we not add Automatic-Module-Name attribute to the jar's manifests, now that Java9 is out? Especially since these files end up in public maven repo.
Kind regards,
Dave
Op 8 november 2017 om 20:40 schreef Jaroslav Tulach <ja...@gmail.com>:
OK, the bits are now in
https://dist.apache.org/repos/dist/release/incubator/netbeans/incubating-netbeans-html4j/
directory since revision 23014.
Since revision 23015 the files are removed from the
https://dist.apache.org/repos/dist/dev/incubator/netbeans/
directory.
The release 1.5 is out! Time to prepare 1.5.1...
-jt
2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
<ja...@gmail.com> wrote:
...Does it still make sense to do official release of
version 1.5 or can we skip that?...
IIUC the only thing left is to move that release under
/dist/release/incubator/netbeans - I think you should do it to
demonstrate the complete process.
If you don't expect people to use that release it's fine to avoid
"advertising" it.
-Bertrand
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
OK, the bits are now in
https://dist.apache.org/repos/dist/release/incubator/netbeans/incubating-netbeans-html4j/
directory since revision 23014.
Since revision 23015 the files are removed from the
https://dist.apache.org/repos/dist/dev/incubator/netbeans/
directory.
The release 1.5 is out! Time to prepare 1.5.1...
-jt
2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> <ja...@gmail.com> wrote:
> > ...Does it still make sense to do official release of
> > version 1.5 or can we skip that?...
>
> IIUC the only thing left is to move that release under
> /dist/release/incubator/netbeans - I think you should do it to
> demonstrate the complete process.
>
> If you don't expect people to use that release it's fine to avoid
> "advertising" it.
>
> -Bertrand
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
OK, the bits are now in
https://dist.apache.org/repos/dist/release/incubator/netbeans/incubating-netbeans-html4j/
directory since revision 23014.
Since revision 23015 the files are removed from the
https://dist.apache.org/repos/dist/dev/incubator/netbeans/
directory.
The release 1.5 is out! Time to prepare 1.5.1...
-jt
2017-11-07 17:20 GMT+01:00 Bertrand Delacretaz <bd...@apache.org>:
> On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
> <ja...@gmail.com> wrote:
> > ...Does it still make sense to do official release of
> > version 1.5 or can we skip that?...
>
> IIUC the only thing left is to move that release under
> /dist/release/incubator/netbeans - I think you should do it to
> demonstrate the complete process.
>
> If you don't expect people to use that release it's fine to avoid
> "advertising" it.
>
> -Bertrand
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
<ja...@gmail.com> wrote:
> ...Does it still make sense to do official release of
> version 1.5 or can we skip that?...
IIUC the only thing left is to move that release under
/dist/release/incubator/netbeans - I think you should do it to
demonstrate the complete process.
If you don't expect people to use that release it's fine to avoid
"advertising" it.
-Bertrand
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach
<ja...@gmail.com> wrote:
> ...Does it still make sense to do official release of
> version 1.5 or can we skip that?...
IIUC the only thing left is to move that release under
/dist/release/incubator/netbeans - I think you should do it to
demonstrate the complete process.
If you don't expect people to use that release it's fine to avoid
"advertising" it.
-Bertrand
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Geertjan Wielenga <ge...@googlemail.com>.
If you want mentors to respond, best to put [mentors] tag at the start of
the subject line, so they can quickly see their insights are needed.
Gj
On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach <ja...@gmail.com>
wrote:
> I see. I started to think about moving the bits to proper place on the
> lasts weekend, but then I realized that the release is so bad, that we need
> release 1.5.1 anyway. Thus I stopped trying.
>
> All bugs reported against 1.5 version have been fixed. It is possible to
> release 1.5.1 now. Does it still make sense to do official release of
> version 1.5 or can we skip that?
>
> -jt
>
>
> 2017-11-05 14:47 GMT+01:00 John D. Ament <jo...@apache.org>:
>
> > Jaroslav,
> >
> > Don't forget that an ASF release isn't official until it's been placed in
> > /dist/release. In your case, it goes into /dist/release/incubator/
> > netbeans.
> >
> > John
> >
> > On Mon, Oct 23, 2017 at 4:29 AM Jaroslav Tulach <
> jaroslav.tulach@gmail.com
> > >
> > wrote:
> >
> > > The vote started four days ago, so it is time to announce the result:
> > > Approved.
> > >
> > > Bertrand Delacretaz: +1
> > > John D. Ament: Here's my +1 to release.
> > > Mark Struberg: +1 IPMC binding ...
> > > Ate Douma: +1 (binding)
> > >
> > > No vote against, four binding approvals, plus one extra:
> > >
> > > Wade Chandler: +1
> > >
> > > Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
> > > -jt
> > >
> > > 2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <jaroslav.tulach@gmail.com
> >:
> > >
> > > > 2017-10-21 14:06 GMT+02:00 Mark Struberg <struberg@yahoo.de.invalid
> >:
> > > >
> > > >> +1 IPMC binding
> > > >>
> > > >> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
> > > >>
> > > >> However when building it from the distribution zip on my macbook
> with
> > > >> java8 144 I sometimes get test errors.
> > > >> All of them in knockout.js, but each time something different:
> > > >>
> > > >
> > > > Thanks for the review and testing. I've recorded the problem as
> > > > https://issues.apache.org/jira/browse/NETBEANS-99
> > > >
> > > >
> > > >> Running the build for the forth time made it succeed.
> > > >> I'd say it's not a blocker for the release, but we might improve the
> > > test
> > > >> setup.
> > > >>
> > > >
> > > > The JavaFX WebView component is a moving target - every update of
> JDK8
> > > > behaves differently. Let's release and seek the fix in subsequent
> > > release.
> > > >
> > > > > txs for rolling the release!
> > > >
> > > > Release early, release often!
> > > > -jt
> > > >
> > > >
> > > > > Am 21.10.2017 um 14:04 schrieb John D. Ament <
> johndament@apache.org
> > >:
> > > >> >
> > > >> > Here's my +1 to release.
> > > >> >
> > > >> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
> > > >> > bdelacretaz@codeconsult.ch> wrote:
> > > >> >
> > > >> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
> > > >> >> <ja...@gmail.com> wrote:
> > > >> >>> ...I'd like to ask you to hold the Incubator
> > > >> >>> PMC vote to release:..
> > > >> >>
> > > >> >> Here's my +1 repeated from the podling list for
> > > >> >>
> > > >> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
> > > >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
> > > >> >>
> > > >> >> Jaroslav's GPG key is included in
> > > >> >> https://people.apache.org/keys/group/netbeans.asc
> > > >> >>
> > > >> >> -Bertrand
> > > >> >>
> > > >> >> ------------------------------------------------------------
> > ---------
> > > >> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > >> >> For additional commands, e-mail: general-help@incubator.apache.
> org
> > > >> >>
> > > >> >>
> > > >>
> > > >>
> > > >> ------------------------------------------------------------
> ---------
> > > >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > >> For additional commands, e-mail: general-help@incubator.apache.org
> > > >>
> > > >>
> > > >
> > >
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
I see. I started to think about moving the bits to proper place on the
lasts weekend, but then I realized that the release is so bad, that we need
release 1.5.1 anyway. Thus I stopped trying.
All bugs reported against 1.5 version have been fixed. It is possible to
release 1.5.1 now. Does it still make sense to do official release of
version 1.5 or can we skip that?
-jt
2017-11-05 14:47 GMT+01:00 John D. Ament <jo...@apache.org>:
> Jaroslav,
>
> Don't forget that an ASF release isn't official until it's been placed in
> /dist/release. In your case, it goes into /dist/release/incubator/
> netbeans.
>
> John
>
> On Mon, Oct 23, 2017 at 4:29 AM Jaroslav Tulach <jaroslav.tulach@gmail.com
> >
> wrote:
>
> > The vote started four days ago, so it is time to announce the result:
> > Approved.
> >
> > Bertrand Delacretaz: +1
> > John D. Ament: Here's my +1 to release.
> > Mark Struberg: +1 IPMC binding ...
> > Ate Douma: +1 (binding)
> >
> > No vote against, four binding approvals, plus one extra:
> >
> > Wade Chandler: +1
> >
> > Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
> > -jt
> >
> > 2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <ja...@gmail.com>:
> >
> > > 2017-10-21 14:06 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:
> > >
> > >> +1 IPMC binding
> > >>
> > >> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
> > >>
> > >> However when building it from the distribution zip on my macbook with
> > >> java8 144 I sometimes get test errors.
> > >> All of them in knockout.js, but each time something different:
> > >>
> > >
> > > Thanks for the review and testing. I've recorded the problem as
> > > https://issues.apache.org/jira/browse/NETBEANS-99
> > >
> > >
> > >> Running the build for the forth time made it succeed.
> > >> I'd say it's not a blocker for the release, but we might improve the
> > test
> > >> setup.
> > >>
> > >
> > > The JavaFX WebView component is a moving target - every update of JDK8
> > > behaves differently. Let's release and seek the fix in subsequent
> > release.
> > >
> > > > txs for rolling the release!
> > >
> > > Release early, release often!
> > > -jt
> > >
> > >
> > > > Am 21.10.2017 um 14:04 schrieb John D. Ament <johndament@apache.org
> >:
> > >> >
> > >> > Here's my +1 to release.
> > >> >
> > >> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
> > >> > bdelacretaz@codeconsult.ch> wrote:
> > >> >
> > >> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
> > >> >> <ja...@gmail.com> wrote:
> > >> >>> ...I'd like to ask you to hold the Incubator
> > >> >>> PMC vote to release:..
> > >> >>
> > >> >> Here's my +1 repeated from the podling list for
> > >> >>
> > >> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
> > >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
> > >> >>
> > >> >> Jaroslav's GPG key is included in
> > >> >> https://people.apache.org/keys/group/netbeans.asc
> > >> >>
> > >> >> -Bertrand
> > >> >>
> > >> >> ------------------------------------------------------------
> ---------
> > >> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >> >> For additional commands, e-mail: general-help@incubator.apache.org
> > >> >>
> > >> >>
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: general-help@incubator.apache.org
> > >>
> > >>
> > >
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by Jaroslav Tulach <ja...@gmail.com>.
I see. I started to think about moving the bits to proper place on the
lasts weekend, but then I realized that the release is so bad, that we need
release 1.5.1 anyway. Thus I stopped trying.
All bugs reported against 1.5 version have been fixed. It is possible to
release 1.5.1 now. Does it still make sense to do official release of
version 1.5 or can we skip that?
-jt
2017-11-05 14:47 GMT+01:00 John D. Ament <jo...@apache.org>:
> Jaroslav,
>
> Don't forget that an ASF release isn't official until it's been placed in
> /dist/release. In your case, it goes into /dist/release/incubator/
> netbeans.
>
> John
>
> On Mon, Oct 23, 2017 at 4:29 AM Jaroslav Tulach <jaroslav.tulach@gmail.com
> >
> wrote:
>
> > The vote started four days ago, so it is time to announce the result:
> > Approved.
> >
> > Bertrand Delacretaz: +1
> > John D. Ament: Here's my +1 to release.
> > Mark Struberg: +1 IPMC binding ...
> > Ate Douma: +1 (binding)
> >
> > No vote against, four binding approvals, plus one extra:
> >
> > Wade Chandler: +1
> >
> > Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
> > -jt
> >
> > 2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <ja...@gmail.com>:
> >
> > > 2017-10-21 14:06 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:
> > >
> > >> +1 IPMC binding
> > >>
> > >> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
> > >>
> > >> However when building it from the distribution zip on my macbook with
> > >> java8 144 I sometimes get test errors.
> > >> All of them in knockout.js, but each time something different:
> > >>
> > >
> > > Thanks for the review and testing. I've recorded the problem as
> > > https://issues.apache.org/jira/browse/NETBEANS-99
> > >
> > >
> > >> Running the build for the forth time made it succeed.
> > >> I'd say it's not a blocker for the release, but we might improve the
> > test
> > >> setup.
> > >>
> > >
> > > The JavaFX WebView component is a moving target - every update of JDK8
> > > behaves differently. Let's release and seek the fix in subsequent
> > release.
> > >
> > > > txs for rolling the release!
> > >
> > > Release early, release often!
> > > -jt
> > >
> > >
> > > > Am 21.10.2017 um 14:04 schrieb John D. Ament <johndament@apache.org
> >:
> > >> >
> > >> > Here's my +1 to release.
> > >> >
> > >> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
> > >> > bdelacretaz@codeconsult.ch> wrote:
> > >> >
> > >> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
> > >> >> <ja...@gmail.com> wrote:
> > >> >>> ...I'd like to ask you to hold the Incubator
> > >> >>> PMC vote to release:..
> > >> >>
> > >> >> Here's my +1 repeated from the podling list for
> > >> >>
> > >> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
> > >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
> > >> >>
> > >> >> Jaroslav's GPG key is included in
> > >> >> https://people.apache.org/keys/group/netbeans.asc
> > >> >>
> > >> >> -Bertrand
> > >> >>
> > >> >> ------------------------------------------------------------
> ---------
> > >> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >> >> For additional commands, e-mail: general-help@incubator.apache.org
> > >> >>
> > >> >>
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: general-help@incubator.apache.org
> > >>
> > >>
> > >
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by "John D. Ament" <jo...@apache.org>.
Jaroslav,
Don't forget that an ASF release isn't official until it's been placed in
/dist/release. In your case, it goes into /dist/release/incubator/netbeans.
John
On Mon, Oct 23, 2017 at 4:29 AM Jaroslav Tulach <ja...@gmail.com>
wrote:
> The vote started four days ago, so it is time to announce the result:
> Approved.
>
> Bertrand Delacretaz: +1
> John D. Ament: Here's my +1 to release.
> Mark Struberg: +1 IPMC binding ...
> Ate Douma: +1 (binding)
>
> No vote against, four binding approvals, plus one extra:
>
> Wade Chandler: +1
>
> Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
> -jt
>
> 2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <ja...@gmail.com>:
>
> > 2017-10-21 14:06 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:
> >
> >> +1 IPMC binding
> >>
> >> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
> >>
> >> However when building it from the distribution zip on my macbook with
> >> java8 144 I sometimes get test errors.
> >> All of them in knockout.js, but each time something different:
> >>
> >
> > Thanks for the review and testing. I've recorded the problem as
> > https://issues.apache.org/jira/browse/NETBEANS-99
> >
> >
> >> Running the build for the forth time made it succeed.
> >> I'd say it's not a blocker for the release, but we might improve the
> test
> >> setup.
> >>
> >
> > The JavaFX WebView component is a moving target - every update of JDK8
> > behaves differently. Let's release and seek the fix in subsequent
> release.
> >
> > > txs for rolling the release!
> >
> > Release early, release often!
> > -jt
> >
> >
> > > Am 21.10.2017 um 14:04 schrieb John D. Ament <jo...@apache.org>:
> >> >
> >> > Here's my +1 to release.
> >> >
> >> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
> >> > bdelacretaz@codeconsult.ch> wrote:
> >> >
> >> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
> >> >> <ja...@gmail.com> wrote:
> >> >>> ...I'd like to ask you to hold the Incubator
> >> >>> PMC vote to release:..
> >> >>
> >> >> Here's my +1 repeated from the podling list for
> >> >>
> >> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
> >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
> >> >>
> >> >> Jaroslav's GPG key is included in
> >> >> https://people.apache.org/keys/group/netbeans.asc
> >> >>
> >> >> -Bertrand
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> >> For additional commands, e-mail: general-help@incubator.apache.org
> >> >>
> >> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >>
> >
>
Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API
Posted by "John D. Ament" <jo...@apache.org>.
Jaroslav,
Don't forget that an ASF release isn't official until it's been placed in
/dist/release. In your case, it goes into /dist/release/incubator/netbeans.
John
On Mon, Oct 23, 2017 at 4:29 AM Jaroslav Tulach <ja...@gmail.com>
wrote:
> The vote started four days ago, so it is time to announce the result:
> Approved.
>
> Bertrand Delacretaz: +1
> John D. Ament: Here's my +1 to release.
> Mark Struberg: +1 IPMC binding ...
> Ate Douma: +1 (binding)
>
> No vote against, four binding approvals, plus one extra:
>
> Wade Chandler: +1
>
> Thanks for making Apache NetBeans HTML/Java API 1.5 release possible!
> -jt
>
> 2017-10-23 10:22 GMT+02:00 Jaroslav Tulach <ja...@gmail.com>:
>
> > 2017-10-21 14:06 GMT+02:00 Mark Struberg <st...@yahoo.de.invalid>:
> >
> >> +1 IPMC binding
> >>
> >> LICENSE, NOTICE, rat, dependencies, signing, etc all looks good.
> >>
> >> However when building it from the distribution zip on my macbook with
> >> java8 144 I sometimes get test errors.
> >> All of them in knockout.js, but each time something different:
> >>
> >
> > Thanks for the review and testing. I've recorded the problem as
> > https://issues.apache.org/jira/browse/NETBEANS-99
> >
> >
> >> Running the build for the forth time made it succeed.
> >> I'd say it's not a blocker for the release, but we might improve the
> test
> >> setup.
> >>
> >
> > The JavaFX WebView component is a moving target - every update of JDK8
> > behaves differently. Let's release and seek the fix in subsequent
> release.
> >
> > > txs for rolling the release!
> >
> > Release early, release often!
> > -jt
> >
> >
> > > Am 21.10.2017 um 14:04 schrieb John D. Ament <jo...@apache.org>:
> >> >
> >> > Here's my +1 to release.
> >> >
> >> > On Thu, Oct 19, 2017 at 8:43 AM Bertrand Delacretaz <
> >> > bdelacretaz@codeconsult.ch> wrote:
> >> >
> >> >> On Thu, Oct 19, 2017 at 2:17 PM, Jaroslav Tulach
> >> >> <ja...@gmail.com> wrote:
> >> >>> ...I'd like to ask you to hold the Incubator
> >> >>> PMC vote to release:..
> >> >>
> >> >> Here's my +1 repeated from the podling list for
> >> >>
> >> >> SHA1(incubating-netbeans-html4j-1.5.zip)=
> >> >> fd77975f1adbcbc4b926e1cfab6865f47db6df3c
> >> >>
> >> >> Jaroslav's GPG key is included in
> >> >> https://people.apache.org/keys/group/netbeans.asc
> >> >>
> >> >> -Bertrand
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> >> For additional commands, e-mail: general-help@incubator.apache.org
> >> >>
> >> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >>
> >
>