You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/08 15:30:25 UTC
[GitHub] [shardingsphere] yx9o commented on a change in pull request #15300: Add test case for ContextManagerBuilderParameter
yx9o commented on a change in pull request #15300:
URL: https://github.com/apache/shardingsphere/pull/15300#discussion_r801760021
##########
File path: shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/ContextManagerBuilderParameterTest.java
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.mode.manager;
+
+import org.apache.shardingsphere.infra.config.RuleConfiguration;
+import org.apache.shardingsphere.infra.config.schema.SchemaConfiguration;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public final class ContextManagerBuilderParameterTest {
+
+ @Test
+ public void assertIsEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(true, true);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(new Properties())
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertTrue(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenAllFieldIsEmpty() {
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(new Properties())
+ .schemaConfigs(Collections.emptyMap())
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertTrue(actualIsEmpty);
+ }
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void assertIsEmptyWhenAllFieldIsNotEmpty() {
+ Properties mockProperties = mock(Properties.class);
+ lenient().when(mockProperties.isEmpty()).thenReturn(false);
+ Collection<RuleConfiguration> mockGlobalRuleConfigs = mock(Collection.class);
+ lenient().when(mockGlobalRuleConfigs.isEmpty()).thenReturn(false);
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(false, false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(mockGlobalRuleConfigs)
+ .props(mockProperties)
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenPropsIsNotEmpty() {
+ Properties mockProperties = mock(Properties.class);
+ when(mockProperties.isEmpty()).thenReturn(false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(mockProperties)
+ .schemaConfigs(Collections.emptyMap())
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void assertIsEmptyWhenGlobalRuleConfigsIsNotEmpty() {
+ Collection<RuleConfiguration> mockGlobalRuleConfigs = mock(Collection.class);
+ when(mockGlobalRuleConfigs.isEmpty()).thenReturn(false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(mockGlobalRuleConfigs)
+ .props(new Properties())
+ .schemaConfigs(Collections.emptyMap())
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenSchemaConfigsIsNotEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(false, false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(new Properties())
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenDataSourcesIsNotEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(false, true);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(new Properties())
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenRuleConfigurationsIsNotEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(true, false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(new Properties())
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void assertIsEmptyWhenOnlyPropsIsEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(true, true);
+ Collection<RuleConfiguration> mockGlobalRuleConfigs = mock(Collection.class);
+ lenient().when(mockGlobalRuleConfigs.isEmpty()).thenReturn(false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(mockGlobalRuleConfigs)
+ .props(new Properties())
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ public void assertIsEmptyWhenOnlyGlobalRuleConfigsIsEmpty() {
+ Map<String, SchemaConfiguration> mockSchemaConfigs = getMockSchemaConfiguration(true, true);
+ Properties mockProperties = mock(Properties.class);
+ lenient().when(mockProperties.isEmpty()).thenReturn(false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(Collections.emptyList())
+ .props(mockProperties)
+ .schemaConfigs(mockSchemaConfigs)
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void assertIsEmptyWhenOnlySchemaConfigsIsEmpty() {
+ Properties mockProperties = mock(Properties.class);
+ Collection<RuleConfiguration> mockGlobalRuleConfigs = mock(Collection.class);
+ lenient().when(mockGlobalRuleConfigs.isEmpty()).thenReturn(false);
+ lenient().when(mockProperties.isEmpty()).thenReturn(false);
+ ContextManagerBuilderParameter contextManagerBuilderParameter = ContextManagerBuilderParameter.builder()
+ .globalRuleConfigs(mockGlobalRuleConfigs)
+ .props(mockProperties)
+ .schemaConfigs(Collections.emptyMap())
+ .build();
+ boolean actualIsEmpty = contextManagerBuilderParameter.isEmpty();
+ assertFalse(actualIsEmpty);
+ }
+
+ private Map<String, SchemaConfiguration> getMockSchemaConfiguration(final boolean dataSourcesIsEmpty, final boolean ruleConfigurationsIsEmpty) {
+ SchemaConfiguration mockSchemaConfiguration = Mockito.mock(SchemaConfiguration.class, RETURNS_DEEP_STUBS);
+ lenient().when(mockSchemaConfiguration.getDataSources().isEmpty()).thenReturn(dataSourcesIsEmpty);
+ lenient().when(mockSchemaConfiguration.getRuleConfigurations().isEmpty()).thenReturn(ruleConfigurationsIsEmpty);
+ Map<String, SchemaConfiguration> schemaConfigs = new HashMap<>();
+ schemaConfigs.put("logic", mockSchemaConfiguration);
+ return schemaConfigs;
+ }
+
Review comment:
Please remove unnecessary blank lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org