You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/02 04:01:50 UTC
[GitHub] [incubator-pinot] sunny209868 commented on issue #4383: [MINOR]
maybe a log bug of PinotAdministrator
sunny209868 commented on issue #4383: [MINOR] maybe a log bug of PinotAdministrator
URL: https://github.com/apache/incubator-pinot/issues/4383#issuecomment-507509067
> When using `pinot-admin.sh CreateSegment` if `overwrite` option is not specified but the output dir existed, it did not have any related prompt on console.
> It should [log error in code](https://github.com/apache/incubator-pinot/blob/master/pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java#L111), but looks print nothing. When using `Logger` instead of `AsyncLogger` will be ok.
> A way to fix it is adding `LogManager.shutdown()` in main or try-catch-finally, is it a proper way?
> Thanks
If there is no overwrite, an exception log is thrown，https://github.com/apache/incubator-pinot/blob/33f583b2a84a8a22143a26c9cc6b80dc2a81563c/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java#L309 @xueyumusic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org