You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xujianhai666 (GitHub)" <gi...@apache.org> on 2019/12/18 14:55:08 UTC
[GitHub] [dubbo-go] xujianhai666 opened pull request #288: fix(core):
add lock for attachment
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] imxyb commented on issue #288: fix(core): add
lock for attachment
Posted by "imxyb (GitHub)" <gi...@apache.org>.
why not use sync.Map?
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on pull request #288: fix(core):
add lock for attachment
Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
agree
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng closed pull request #288: fix(core):
add lock for attachment
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
[ pull request closed by fangyincheng ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #288:
fix(core): add lock for attachment
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
func (rw *RWMutex) RLock()
func (rw *RWMutex) RUnlock()
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #288:
fix(core): add lock for attachment
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
should it be a rwmutex?
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #288: fix(core):
add lock for attachment
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=h1) Report
> Merging [#288](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d65659ff25b4c4af5dc137ba8a924a9c93a7af8a?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #288 +/- ##
===========================================
+ Coverage 65.52% 65.55% +0.02%
===========================================
Files 111 111
Lines 7063 7063
===========================================
+ Hits 4628 4630 +2
+ Misses 1978 1977 -1
+ Partials 457 456 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=footer). Last update [d65659f...e9a53a4](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] xujianhai666 commented on pull request #288:
fix(core): add lock for attachment
Posted by "xujianhai666 (GitHub)" <gi...@apache.org>.
yes, done @fangyincheng
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] xujianhai666 commented on pull request #288:
fix(core): add lock for attachment
Posted by "xujianhai666 (GitHub)" <gi...@apache.org>.
@fangyincheng done
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #288: fix(core):
add lock for attachment
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=h1) Report
> Merging [#288](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d65659ff25b4c4af5dc137ba8a924a9c93a7af8a?src=pr&el=desc) will **increase** coverage by `0.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #288 +/- ##
===========================================
+ Coverage 65.52% 66.45% +0.93%
===========================================
Files 111 112 +1
Lines 7063 7167 +104
===========================================
+ Hits 4628 4763 +135
+ Misses 1978 1941 -37
- Partials 457 463 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0%> (-9.38%)` | :arrow_down: |
| [config/service.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2UuZ28=) | `92.3% <0%> (-7.7%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `97.75% <0%> (-2.25%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.54% <0%> (ø)` | :arrow_up: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `50% <0%> (ø)` | :arrow_up: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `91.17% <0%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `69.28% <0%> (+0.3%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.39% <0%> (+0.32%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/288/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=footer). Last update [d65659f...944e6dc](https://codecov.io/gh/apache/dubbo-go/pull/288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/288 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org