[jira] [Comment Edited] (HDDS-3479) Use SCMMetadataStore instead of low level DBStore

["Jorge Cespedes (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092700#comment-17092700 ] 

Jorge Cespedes edited comment on HDDS-3479 at 4/26/20, 12:39 PM:
-----------------------------------------------------------------

Does the ticket also include renaming SCMMetadataStoreRDBImpl by removing the (RDB) part? Or will this be a different ticket? I've implemented the changes considering also the renaming of the class. Now I need some help to run the tests.


was (Author: jsoft88):
Does the ticket also include renaming SCMMetadataStoreRDBImpl by removing the (RDB) part? Or will this be a different ticket?

> Use SCMMetadataStore instead of low level DBStore
> -------------------------------------------------
>
>                 Key: HDDS-3479
>                 URL: https://issues.apache.org/jira/browse/HDDS-3479
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Marton Elek
>            Priority: Major
>              Labels: newbie
>
> Suggested by Nanda in https://github.com/apache/hadoop-ozone/pull/700
> Context: we have a low-level DBStoreBuilder with separated DB definition (SCMDBDefinition). But as we have a higher level wrapper class (scmMetadataStore) It seems to be more reasonable to use ScmMetadataStore everywhere inside SCM
> (Currently It's called SCMMetadataStoreRDBImpl but it's proposed to remove R(DB) from the name as it's no more RocksDB specific)
> bq. If we are going with renaming and using it, it's better to use SCMMetadataStoreRDBImpl in all the places rather than DBStoreBuilder.createDBStore(conf, new SCMDBDefinition()
> bq. 
> Instead of this:
> {code}
> DBStore dbStore = DBStoreBuilder.createDBStore(conf, new SCMDBDefinition());
> Table<PipelineID, Pipeline> pipelineTable = SCMDBDefinition.PIPELINES.getTable(dbStore);
> dbStore.close();
> {code}
> we can use this:
> {code}
> SCMMetadataStore scmMetadataStore = new SCMMetadataStoreRDBImpl(conf);
> Table<PipelineID, Pipeline> pipelineTable = scmMetadataStore.getPipelineTable();
> scmMetadataStore.close();
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org