[GitHub] [calcite] chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field
URL: https://github.com/apache/calcite/pull/1186#discussion_r279174752
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java
 ##########
 @@ -836,7 +836,7 @@ private static ImmutableBitSet analyzeGroupExpr(SqlValidatorScope scope,
       SqlIdentifier expr = (SqlIdentifier) expandedGroupExpr;
 
       // column references should be fully qualified.
-      assert expr.names.size() == 2;
+      assert expr.names.size() >= 2;
       String originalRelName = expr.names.get(0);
       String originalFieldName = expr.names.get(1);
 
 
 Review comment:
   Maybe we should check whether the first name is the name of a table alias in scope.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services