[jira] [Resolved] (PIG-2119) DuplicateForEachColumnRewrite makes assumptions about the position of LOGGenerate in the plan

["Daniel Dai (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai resolved PIG-2119.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.11
     Hadoop Flags: Reviewed

Unit tests pass. Test-patch:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 458 release audit warnings (more than the trunk's current 447 warnings).

All new files has proper header.

Patch committed to both trunk and 0.10 branch.
                
> DuplicateForEachColumnRewrite makes assumptions about the position of LOGGenerate in the plan
> ---------------------------------------------------------------------------------------------
>
>                 Key: PIG-2119
>                 URL: https://issues.apache.org/jira/browse/PIG-2119
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0, 0.9.1
>            Reporter: Gianmarco De Francisci Morales
>            Assignee: Daniel Dai
>             Fix For: 0.10, 0.11
>
>         Attachments: PIG-2119-1.patch
>
>
> The input:
> {code}
> grunt> cat b.txt
> a       11
> b       3
> c       10
> a       12
> b       10
> c       15
> {code}
> The script:
> {code}
> a = load 'b.txt' AS (id:chararray, num:int);
> b = group a by id;
> c = foreach b { 
>   d = order a by num DESC;
>   n = COUNT(a);
>   e = limit d 1;
>   generate n;
> }
> {code}
> The exception:
> {code}
> Caused by: java.lang.ClassCastException: org.apache.pig.newplan.logical.relational.LOLimit cannot be cast to org.apache.pig.newplan.logical.relational.LOGenerate
>         at org.apache.pig.newplan.logical.rules.DuplicateForEachColumnRewrite$DuplicateForEachColumnRewriteTransformer.check(DuplicateForEachColumnRewrite.java:87)
>         at org.apache.pig.newplan.optimizer.PlanOptimizer.optimize(PlanOptimizer.java:108)
> {code}
> I know the script is a bit pointless, but I was just testing and modifying the script bit by bit.
> If I remove the limit in any case I get the same exception but with LOSort.
> The problem, I think, is that the rule assumes there is only 1 sink in the nested block and that this sink is a LOGenerate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira