You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/08/12 03:12:36 UTC
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm
gozer@apache.org wrote:
> gozer 2004/08/11 15:49:15
>
> Modified: . Changes
> xs/tables/current/Apache ConstantsTable.pm
> Log:
> Add :context group of constants for check_cmd_context().
> NOT_IN_VIRTUALHOST, NOT_IN_LIMIT, NOT_IN_DIRECTORY, NOT_IN_LOCATION,
> NOT_IN_FILES, NOT_IN_DIR_LOC_FILE & GLOBAL_ONLY
>
> Revision Changes Path
> 1.440 +4 -0 modperl-2.0/Changes
>
> Index: Changes
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Changes,v
> retrieving revision 1.439
> retrieving revision 1.440
> diff -u -r1.439 -r1.440
> --- Changes 11 Aug 2004 18:16:29 -0000 1.439
> +++ Changes 11 Aug 2004 22:49:15 -0000 1.440
> @@ -12,6 +12,10 @@
>
> =item 1.99_15-dev
>
> +Add :context group of constants for check_cmd_context().
> +NOT_IN_VIRTUALHOST, NOT_IN_LIMIT, NOT_IN_DIRECTORY, NOT_IN_LOCATION,
> +NOT_IN_FILES, NOT_IN_DIR_LOC_FILE & GLOBAL_ONLY [Gozer]
> +
> Removed Apache::Command method soak_end_container [Gozer]
>
> Removed Apache::Module methods (dynamic_load_handle and
>
>
>
> 1.41 +9 -0 modperl-2.0/xs/tables/current/Apache/ConstantsTable.pm
>
> Index: ConstantsTable.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/xs/tables/current/Apache/ConstantsTable.pm,v
> retrieving revision 1.40
> retrieving revision 1.41
> diff -u -r1.40 -r1.41
> --- ConstantsTable.pm 4 May 2004 06:20:57 -0000 1.40
> +++ ConstantsTable.pm 11 Aug 2004 22:49:15 -0000 1.41
> @@ -56,6 +56,15 @@
> 'OPT_MULTI',
> 'OPT_ALL'
> ],
> + 'context' => [
> + 'NOT_IN_VIRTUALHOST',
> + 'NOT_IN_LIMIT',
> + 'NOT_IN_DIRECTORY',
> + 'NOT_IN_LOCATION',
> + 'NOT_IN_FILES',
> + 'NOT_IN_DIR_LOC_FILE',
> + 'GLOBAL_ONLY',
> + ],
Have you by chance noticed:
% cat xs/tables/current/Apache/ConstantsTable.pm
package Apache::ConstantsTable;
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
# ! WARNING: generated by Apache::ParseSource/0.02
# ! Mon May 3 13:30:11 2004
# ! do NOT edit, any changes will be lost !
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
The next time the source scan will be run, your changes will be lost.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
>
>>>Have you by chance noticed:
>>>
>>>% cat xs/tables/current/Apache/ConstantsTable.pm
>>>package Apache::ConstantsTable;
>>>
>>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>>># ! WARNING: generated by Apache::ParseSource/0.02
>>># ! Mon May 3 13:30:11 2004
>>># ! do NOT edit, any changes will be lost !
>>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>>>
>>>The next time the source scan will be run, your changes will be lost.
>>
>>
>>in all fairness, we've hand-edited that file tons of times, so it's not
>>really like there is no precident for it (and I'm the one who told him to
>>just add them :)
>
>
> Luckily, that is not the case for a few months already. And it saved me
> a lot of time, since I started working on the API polish.
>
>
>>I guess that along with the edit is adding the 'context' group to
>>Apache::ParseSource so that the table is correctly generated next time
>>somebody runs it.
>
>
> No, not really. 'make source_scan' will do the edit for you. That's the
> whole point of it. The only reason we were doing it manually is because
> it was broken. It works now. So one needs to tweaks ParseSource to pick
> up that group.
Thanks for pointing it out, I've checked in a revised version of SourceScan.pm
>
>>sorry.
>
>
> No problem :)
>
>
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>Have you by chance noticed:
>>
>>% cat xs/tables/current/Apache/ConstantsTable.pm
>>package Apache::ConstantsTable;
>>
>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>># ! WARNING: generated by Apache::ParseSource/0.02
>># ! Mon May 3 13:30:11 2004
>># ! do NOT edit, any changes will be lost !
>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>>
>>The next time the source scan will be run, your changes will be lost.
>
>
> in all fairness, we've hand-edited that file tons of times, so it's not
> really like there is no precident for it (and I'm the one who told him to
> just add them :)
Luckily, that is not the case for a few months already. And it saved me
a lot of time, since I started working on the API polish.
> I guess that along with the edit is adding the 'context' group to
> Apache::ParseSource so that the table is correctly generated next time
> somebody runs it.
No, not really. 'make source_scan' will do the edit for you. That's the
whole point of it. The only reason we were doing it manually is because
it was broken. It works now. So one needs to tweaks ParseSource to pick
up that group.
> sorry.
No problem :)
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Have you by chance noticed:
>
> % cat xs/tables/current/Apache/ConstantsTable.pm
> package Apache::ConstantsTable;
>
> # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> # ! WARNING: generated by Apache::ParseSource/0.02
> # ! Mon May 3 13:30:11 2004
> # ! do NOT edit, any changes will be lost !
> # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>
> The next time the source scan will be run, your changes will be lost.
in all fairness, we've hand-edited that file tons of times, so it's not
really like there is no precident for it (and I'm the one who told him to
just add them :)
I guess that along with the edit is adding the 'context' group to
Apache::ParseSource so that the table is correctly generated next time
somebody runs it.
sorry.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org