[GitHub] [hudi] CTTY commented on a diff in pull request #6882: [WIP][HUDI-3625] Object Store Storage Strategy

[GitBox <gi...@apache.org>]

CTTY commented on code in PR #6882:
URL: https://github.com/apache/hudi/pull/6882#discussion_r989554325


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -167,6 +167,12 @@ public HoodieTableFileSystemView(HoodieTableMetaClient metaClient, HoodieTimelin
     addFilesToView(fileStatuses);
   }
 
+  public HoodieTableFileSystemView(HoodieTableMetaClient metaClient, HoodieTimeline visibleActiveTimeline,
+      Map<String, FileStatus[]> partitionFiles) {
+    this(metaClient, visibleActiveTimeline);
+    addFilesToView(partitionFiles);
+  }
+

Review Comment:
   On the reading side, FSView has to be aware of physical path. Statuses got passed in should be referring to the actual file. But this breaks the logic of extracting partition name from file path (See L212 of [this](https://github.com/apache/hudi/pull/6882/files#diff-201f1e7b1c7bce22fc142968e77cf67eea5c9d2946c8f8244d854fb6754b32a8)) 
   
   Thus I added this new constructor to pass the partition info down.  And this should replace most of usages of another constructor at L164



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org