You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/05 09:03:00 UTC
[GitHub] [spark] cloud-fan opened a new pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
cloud-fan opened a new pull request #30261:
URL: https://github.com/apache/spark/pull/30261
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Rename `OffsetWindowSpec` to `OffsetWindowFunction`, as it's the base class for all offset based window functions.
2. Refine and add more comments.
3. Remove `isRelative` as it's useless.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
code refinement
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722399891
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35260/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722399910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30261:
URL: https://github.com/apache/spark/pull/30261#discussion_r517906042
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
##########
@@ -57,12 +57,8 @@ import org.apache.spark.sql.types.{CalendarIntervalType, DateType, IntegerType,
* 3. CURRENT ROW AND 1 FOLLOWING
* 4. 1 PRECEDING AND 1 FOLLOWING
* 5. 1 FOLLOWING AND 2 FOLLOWING
- * - Offset frame: The frame consist of one row, which is an offset number of rows. There are three
- * implement of offset frame.
- * 1. [[FrameLessOffsetWindowFunction]] returns the value of the input column offset by a number
- * of rows according to the current row.
- * 2. [[UnboundedOffsetWindowFunctionFrame]] and [[UnboundedPrecedingOffsetWindowFunctionFrame]]
- * returns the value of the input column offset by a number of rows within the frame.
+ * - Offset frame: The frame consist of one row, which is an offset number of rows away from the
+ * current row. Only [[OffsetWindowFunction]]s can be processed in an offset frame.
Review comment:
Do we need to introduce `FrameLessOffsetWindowFunctionFrame`, `UnboundedOffsetWindowFunctionFrame` and `UnboundedPrecedingOffsetWindowFunctionFrame`？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722283955
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35254/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30261:
URL: https://github.com/apache/spark/pull/30261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722832295
merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722243730
**[Test build #130644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130644/testReport)** for PR 30261 at commit [`a84ff03`](https://github.com/apache/spark/commit/a84ff03773d88eb7af9bddcd33325130e691e489).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722243730
**[Test build #130644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130644/testReport)** for PR 30261 at commit [`a84ff03`](https://github.com/apache/spark/commit/a84ff03773d88eb7af9bddcd33325130e691e489).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722521690
**[Test build #130649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130649/testReport)** for PR 30261 at commit [`b87eed2`](https://github.com/apache/spark/commit/b87eed292049027cf777a6f131bff7bac08681bb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722522857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722387539
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35260/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722283980
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722399910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722365820
**[Test build #130649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130649/testReport)** for PR 30261 at commit [`b87eed2`](https://github.com/apache/spark/commit/b87eed292049027cf777a6f131bff7bac08681bb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30261:
URL: https://github.com/apache/spark/pull/30261#discussion_r517918038
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -185,7 +186,7 @@ trait WindowExecBase extends UnaryExecNode {
target,
ordinal,
// OFFSET frame functions are guaranteed be OffsetWindowSpec.
Review comment:
OffsetWindowSpec -> OffsetWindowFunction
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -196,7 +197,7 @@ trait WindowExecBase extends UnaryExecNode {
target,
ordinal,
// OFFSET frame functions are guaranteed be OffsetWindowSpec.
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -208,7 +209,7 @@ trait WindowExecBase extends UnaryExecNode {
target,
ordinal,
// OFFSET frame functions are guaranteed be OffsetWindowSpec.
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722283993
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35254/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722365820
**[Test build #130649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130649/testReport)** for PR 30261 at commit [`b87eed2`](https://github.com/apache/spark/commit/b87eed292049027cf777a6f131bff7bac08681bb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722377713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722377713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722271270
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35254/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30261:
URL: https://github.com/apache/spark/pull/30261#discussion_r517917929
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -208,7 +209,7 @@ trait WindowExecBase extends UnaryExecNode {
target,
ordinal,
// OFFSET frame functions are guaranteed be OffsetWindowSpec.
Review comment:
OffsetWindowSpec -> OffsetWindowFunction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722376581
**[Test build #130644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130644/testReport)** for PR 30261 at commit [`a84ff03`](https://github.com/apache/spark/commit/a84ff03773d88eb7af9bddcd33325130e691e489).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait OffsetWindowFunction extends WindowFunction `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722242449
cc @beliefer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30261: [SPARK-32934][SQL][followup] refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722283980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722522857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #30261: [SPARK-32934][SQL][FOLLOW-UP] Refine class naming and code comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30261:
URL: https://github.com/apache/spark/pull/30261#issuecomment-722784853
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org