You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2014/08/01 20:49:41 UTC

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

    [ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082737#comment-14082737 ] 

Mike Drob commented on CURATOR-79:
----------------------------------

I tried running the attached test against the current master branch and was not able to reproduce a failure. We should probably add the test to the code for completeness, but otherwise I'm tempted to suggest that we close this as 'Cannot Reproduce'

> InterProcessMutex doesn't clean up after interrupt
> --------------------------------------------------
>
>                 Key: CURATOR-79
>                 URL: https://issues.apache.org/jira/browse/CURATOR-79
>             Project: Apache Curator
>          Issue Type: Bug
>    Affects Versions: 2.0.0-incubating, 2.1.0-incubating, 2.2.0-incubating, 2.3.0
>            Reporter: Orcun Simsek
>            Assignee: Jordan Zimmerman
>
> InterProcessMutex can deadlock if a thread is interrupted during acquire().  Specifically, CreateBuilderImpl.pathInForeground submits a create request to ZooKeeper, and an InterruptedException is thrown after the node is created in ZK but before ZK.create returns. ZK.create propagates a non-KeeperException, so Curator assumes the create has failed, but does not retry, and the node is now orphaned. At some point in the future, the node becomes the next in the acquisition sequence, but is not reclaimed as the ZK session has not expired.
> <stack trace attached in comments below>
> Curator should catch the InterruptedException and other non-KeeperExceptions, and delete the created node before propagating these exceptions.
> (as originally discussed on https://groups.google.com/forum/#!topic/curator-users/9ii5of8SbdQ)



--
This message was sent by Atlassian JIRA
(v6.2#6252)