[GitHub] [pulsar] HQebupt commented on a change in pull request #15010: [integration] Add messaging etcd integration tests

[GitBox <gi...@apache.org>]

HQebupt commented on a change in pull request #15010:
URL: https://github.com/apache/pulsar/pull/15010#discussion_r841189605



##########
File path: managed-ledger/pom.xml
##########
@@ -99,14 +99,14 @@
       </exclusions>
     </dependency>
     <dependency>
-       <groupId>io.dropwizard.metrics</groupId>

Review comment:
       Better to keep it as it is because it has nothing to do with this issue.

##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -143,11 +143,7 @@ public ProxyServiceStarter(String[] args) throws Exception {
             // load config file
             config = PulsarConfigurationLoader.create(configFile, ProxyConfiguration.class);
 
-            if (isBlank(metadataStoreUrl)) {

Review comment:
        _Use zookeeperServers from command line if metadataStoreUrl is empty._  How to handle if the metadataStoreUrl is empty ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org