You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2020/12/09 19:57:28 UTC

[Bug 64972] New: HSSFPictureData#getPictureType() disagrees with documented interface

https://bz.apache.org/bugzilla/show_bug.cgi?id=64972

            Bug ID: 64972
           Summary: HSSFPictureData#getPictureType() disagrees with
                    documented interface
           Product: POI
           Version: 4.1.2-FINAL
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
          Assignee: dev@poi.apache.org
          Reporter: marius@volkhart.com
  Target Milestone: ---

HSSFPictureData#getPictureType() is documented as returning -1 if the image
type is unknown. However, the interface, PictureData, which HssfPictureData
implements, documents that function as returning 0 if the image type is
unknown. 

XSSFPictureData follows the interface spec.

I don't know what POI's policy is on interface implementations, but I would
think HSSFPictureData should match the documented behavior, or the
documentation should be updated to something like "0 or less" if the type is
unknown.

There was previous discussion around a switch to enums for this method on
XWPFPictureData: https://bz.apache.org/bugzilla/show_bug.cgi?id=59836 but it
looks like that change wasn't made.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 64972] HSSFPictureData#getPictureType() disagrees with documented interface

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64972

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
added r1884270

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org