[GitHub] [spark] mridulm commented on a diff in pull request #40749: [SPARK-43100][CORE] Mismatch of field name in log event writer and parser for push shuffle metrics

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #40749:
URL: https://github.com/apache/spark/pull/40749#discussion_r1165075248


##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -545,7 +545,7 @@ private[spark] object JsonProtocol {
       g.writeNumberField("Total Records Read", taskMetrics.shuffleReadMetrics.recordsRead)
       g.writeNumberField("Remote Requests Duration",
         taskMetrics.shuffleReadMetrics.remoteReqsDuration)
-      g.writeFieldName("Push Based Shuffle")
+      g.writeFieldName("Shuffle Push Read Metrics")

Review Comment:
   The discussion was to rename it to `"Push Based Shuffle"` (see [here](https://github.com/apache/spark/pull/36165#discussion_r1005261036))
   I would suggest renaming `Shuffle Push Read Metrics` to `Push Based Shuffle` instead - this is in context of read metrics anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org