You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 12:28:37 UTC

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10040: ARROW-11565: [C++][Gandiva] Modify upper()/lower() logic to make them work for utf8 strings

anthonylouisbsb commented on a change in pull request #10040:
URL: https://github.com/apache/arrow/pull/10040#discussion_r623004025



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -1000,5 +1172,47 @@ void ExportedStubFunctions::AddMappings(Engine* engine) const {
   engine->AddGlobalMappingForFunc("gdv_fn_sha256_decimal128",
                                   types->i8_ptr_type() /*return_type*/, args,
                                   reinterpret_cast<void*>(gdv_fn_sha256_decimal128));
+
+  // gdv_fn_utf8_char_length
+  args = {

Review comment:
       Functions removed from global mapping.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org