You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jothi Padmanabhan (JIRA)" <ji...@apache.org> on 2009/06/01 09:54:07 UTC
[jira] Created: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
--------------------------------------------------------------------------------
Key: HADOOP-5948
URL: https://issues.apache.org/jira/browse/HADOOP-5948
Project: Hadoop Core
Issue Type: Test
Reporter: Jothi Padmanabhan
Assignee: Jothi Padmanabhan
TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jothi Padmanabhan updated HADOOP-5948:
--------------------------------------
Attachment: hadoop-5948.patch
Patch that changes the test not to use MiniMR
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715261#action_12715261 ]
Philip Zeyliger commented on HADOOP-5948:
-----------------------------------------
+1 on making tests faster.
{quote}
private static String TEST_ROOT_DIR =
new File(System.getProperty("test.build.data", "/tmp")).toURI()
.toString().replace(' ', '+');
{quote}
Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary?
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718609#action_12718609 ]
Hudson commented on HADOOP-5948:
--------------------------------
Integrated in Hadoop-trunk #863 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/863/])
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jothi Padmanabhan updated HADOOP-5948:
--------------------------------------
Component/s: test
Fix Version/s: 0.21.0
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715106#action_12715106 ]
Hadoop QA commented on HADOOP-5948:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409543/hadoop-5948.patch
against trunk revision 780567.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/console
This message is automatically generated.
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-5948:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Jothi!
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jothi Padmanabhan updated HADOOP-5948:
--------------------------------------
Status: Patch Available (was: Open)
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5948) Modify TestJavaSerialization to use
LocalJobRunner instead of MiniMR/DFS cluster
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715409#action_12715409 ]
Jothi Padmanabhan commented on HADOOP-5948:
-------------------------------------------
bq. Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary?
I do not think the string replacement is necessary. My guess is that this must have been added by somebody who had spaces in their test.build.data and has ever since found its way into all other test cases. I could be wrong though!
> Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster
> --------------------------------------------------------------------------------
>
> Key: HADOOP-5948
> URL: https://issues.apache.org/jira/browse/HADOOP-5948
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5948.patch
>
>
> TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.