You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/08 09:31:00 UTC
[jira] [Commented] (METRON-1861) REST fails to start when LDAP
enabled and 'Active Spring profiles' config is empty
[ https://issues.apache.org/jira/browse/METRON-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679495#comment-16679495 ]
ASF GitHub Bot commented on METRON-1861:
----------------------------------------
GitHub user anandsubbu opened a pull request:
https://github.com/apache/metron/pull/1256
METRON-1861: REST fails to start when LDAP enabled and 'Active Spring profiles' config is empty
## Contributor Comments
Set 'Active Spring profiles' to just `ldap`, when `metron_spring_profiles_active` is blank.
### Testing Steps
1. Set 'LDAP Enabled' to On and set 'Active Spring profiles' as blank
2. Restart REST service and validate that it starts up fine.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anandsubbu/incubator-metron METRON-1861
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1256
----
commit ad781b6da1b03524ea63c318ebe68c47758c5b64
Author: Anand Subramanian <as...@...>
Date: 2018-11-08T09:24:45Z
Handle case when metron_spring_profiles_active is empty
----
> REST fails to start when LDAP enabled and 'Active Spring profiles' config is empty
> ----------------------------------------------------------------------------------
>
> Key: METRON-1861
> URL: https://issues.apache.org/jira/browse/METRON-1861
> Project: Metron
> Issue Type: Bug
> Reporter: Anand Subramanian
> Assignee: Anand Subramanian
> Priority: Major
>
> When 'LDAP enabled' (in Configs -> Metron -> Security tab) is set to 'On' and the 'Active Spring profiles' (in Configs -> Metron -> REST tab) is blank, REST service fails to start with the following error:
>
> {code:java}
> 18/11/08 08:10:02 ERROR boot.SpringApplication: Application run failed
> java.lang.IllegalArgumentException: Invalid profile []: must contain text
> at org.springframework.core.env.AbstractEnvironment.validateProfile(AbstractEnvironment.java:365)
> at org.springframework.core.env.AbstractEnvironment.setActiveProfiles(AbstractEnvironment.java:256)
> at org.springframework.core.env.AbstractEnvironment.doGetActiveProfiles(AbstractEnvironment.java:242)
> at org.springframework.core.env.AbstractEnvironment.getActiveProfiles(AbstractEnvironment.java:226)
> at org.springframework.boot.SpringApplication.configureProfiles(SpringApplication.java:522)
> at org.springframework.boot.SpringApplication.configureEnvironment(SpringApplication.java:479)
> at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:357)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:317)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1255)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1243)
> at org.apache.metron.rest.MetronRestApplication.main(MetronRestApplication.java:36){code}
>
> This is because the 'metron_spring_profiles_active' is set to the value ',ldap' which is not valid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)